DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v2 1/3] net/iavf: fix crash in Tx drain on PF reset
Date: Wed, 4 Nov 2026 17:51:59 +0000	[thread overview]
Message-ID: <autwv5TPa2cey85W@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20261104095510.10246-2-ciara.loftus@intel.com>

On Wed, Nov 04, 2026 at 09:55:07AM +0000, Ciara Loftus wrote:
> The Tx cleanup helpers check the DD bit of the descriptor at the next
> RS boundary and assume software has already posted it. The burst path
> guarantees this by only cleaning up when nb_tx_free drops below
> tx_free_thresh, but iavf_dev_tx_drain() called the helpers on any
> non-empty queue.
> 
> With fewer than tx_rs_thresh descriptors outstanding, that descriptor
> still held the DESC_DONE value set by reset_tx_queue(), so the helpers
> treated the block as complete and freed NULL (or already freed) mbufs,
> crashing on PF reset.
> 
> Only clean up a queue once a full RS block is outstanding.
> 
> Fixes: 30e1aab01bae ("net/iavf: drain in-flight Tx before reset")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
>  drivers/net/intel/iavf/iavf_rxtx.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2026-11-04 17:52 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  9:55 [PATCH v2 0/3] iavf reset path fixes Ciara Loftus
2026-11-04  9:55 ` [PATCH v2 1/3] net/iavf: fix crash in Tx drain on PF reset Ciara Loftus
2026-11-04 17:51   ` Bruce Richardson [this message]
2026-11-04  9:55 ` [PATCH v2 2/3] net/iavf: fix event handler leak on init failure Ciara Loftus
2026-11-04 17:52   ` Bruce Richardson
2026-11-04  9:55 ` [PATCH v2 3/3] net/iavf: fix watchdog clearing reset state during recovery Ciara Loftus
2026-11-04 18:00   ` Bruce Richardson
2026-11-05 12:32 ` [PATCH v3 0/4] iavf reset path fixes Ciara Loftus
2026-11-05 12:32   ` [PATCH v3 1/4] net/iavf: fix crash in Tx drain on PF reset Ciara Loftus
2026-11-05 12:32   ` [PATCH v3 2/4] net/iavf: fix event handler leak on init failure Ciara Loftus
2026-11-05 12:32   ` [PATCH v3 3/4] net/iavf: fix watchdog clearing reset state during recovery Ciara Loftus
2026-11-05 12:32   ` [PATCH v3 4/4] net/iavf: fix watchdog enable racing disable Ciara Loftus
2026-11-06  9:40   ` [PATCH v4 0/4] iavf reset path fixes Ciara Loftus
2026-11-06  9:40     ` [PATCH v4 1/4] net/iavf: fix crash in Tx drain on PF reset Ciara Loftus
2026-11-06  9:40     ` [PATCH v4 2/4] net/iavf: fix event handler leak on init failure Ciara Loftus
2026-11-06  9:40     ` [PATCH v4 3/4] net/iavf: fix watchdog clearing reset state during recovery Ciara Loftus
2026-11-10 10:47       ` Bruce Richardson
2026-11-06  9:40     ` [PATCH v4 4/4] net/iavf: fix watchdog enable racing disable Ciara Loftus
2026-11-10 10:48       ` Bruce Richardson
2026-11-10 10:51     ` [PATCH v4 0/4] iavf reset path fixes Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=autwv5TPa2cey85W@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox