From: Bruce Richardson <bruce.richardson@intel.com>
To: <stephen@networkplumber.org>
Cc: <dev@dpdk.org>
Subject: Re: [DPDK/core Bug 2135] eal: unreachable code warning
Date: Tue, 17 Nov 2026 17:21:57 +0000 [thread overview]
Message-ID: <avyNNcwSkwzkf2_J@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <bug-2135-3@https.bugs.dpdk.org/>
On Tue, Nov 17, 2026 at 05:07:54PM +0000, bugzilla@dpdk.org wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=2135
>
> Bug ID: 2135
> Summary: eal: unreachable code warning
> Product: DPDK
> Version: 26.11
> Hardware: All
> OS: All
> Status: UNCONFIRMED
> Severity: minor
> Priority: Low
> Component: core
> Assignee: dev@dpdk.org
> Reporter: stephen@networkplumber.org
> Target Milestone: ---
>
> Building with clang and -Wunreachable-code finds this:
>
> [18/3982] Compiling C object lib/librte_eal.a.p/eal_common_rte_version.c.o
> ../lib/eal/common/rte_version.c:40:3: warning: code will never be executed
> [-Wunreachable-code]
> 40 | snprintf(version, sizeof(version), "%s %d.%02d.%d",
> | ^~~~~~~~
> ../lib/eal/common/rte_version.c:39:32: note: silence by adding parentheses to
> mark code as explicitly dead
> 39 | if (strlen(RTE_VER_SUFFIX) == 0)
> | ^
> | /* DISABLES CODE */ ( )
> 1 warning generated.
>
> It can be fixed by adding parens, using sizeof, or useing RTE_VERSION which is
> already built by meson.
>
Not a bug. The code is correct, but technically one or both branches are
unreachable depending on whether we are at an RC version or not. This
construct with dead code I still view as superior to using #ifdefs on the
SUFFIX. We can't use RTE_VERSION as that's a numeric version number only,
which doesn't include the "rc" part (see definition in rte_version.h).
/Bruce
prev parent reply other threads:[~2026-11-17 17:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:07 [DPDK/core Bug 2135] eal: unreachable code warning bugzilla
2026-11-17 17:21 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avyNNcwSkwzkf2_J@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox