DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [PATCH v1 1/1] net/ixgbe: fix PTP packet detection
Date: Fri, 20 Nov 2026 11:39:50 +0000	[thread overview]
Message-ID: <awAxhrA4bWWf6wFO@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <a981e3347f36b5cda348c27448eba3c5d83e98a7.1795170123.git.anatoly.burakov@intel.com>

On Fri, Nov 20, 2026 at 10:22:09AM +0000, Anatoly Burakov wrote:
> Currently, the Rx path decides whether a packet is a PTP packet by looking
> at which ETQF filter index it was matched against, and it expects the
> 1588 filter to always be at index 3. However, when the Ethertype filter
> table was made dynamic, the 1588 filter started being installed into
> the first free slot instead, so the Rx path may not recognize PTP packets
> and, if that happens, never sets RTE_MBUF_F_RX_IEEE1588_PTP on them.
> 
> Fix it by always reserving the last ETQF slot for the 1588 filter, and
> only allocating the remaining slots dynamically.
> 
> Fixes: 3ba3f96f8f71 ("net/ixgbe: make ethertype filter table dynamic")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  drivers/net/intel/ixgbe/ixgbe_ethdev.c | 33 +++++---------------------
>  drivers/net/intel/ixgbe/ixgbe_ethdev.h |  9 +++----
>  drivers/net/intel/ixgbe/ixgbe_rxtx.c   |  5 ++--
>  3 files changed, 13 insertions(+), 34 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Despite it being late in cycle, after discussion with Anatoly and asking AI
to do a detailed review of this (which came back clean), I'm going to take
this patch.

Applied to dpdk-next-net-intel.
Thanks,
/Bruce


      reply	other threads:[~2026-11-20 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:22 [PATCH v1 1/1] net/ixgbe: fix PTP packet detection Anatoly Burakov
2026-11-20 11:39 ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awAxhrA4bWWf6wFO@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox