From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] net/virtio-user: fix multiqueue support with vhost kernel Date: Tue, 12 Mar 2019 13:53:00 +0100 Message-ID: References: <20190312071307.19393-1-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: stephen@networkplumber.org, ferruh.yigit@intel.com, stable@dpdk.org To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Return-path: In-Reply-To: <20190312071307.19393-1-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/12/19 8:13 AM, Tiwei Bie wrote: > The multiqueue support in virtio-user with vhost kernel backend > is broken when tap name isn't specified by users explicitly, > because the tap name returned by ioctl(TUNSETIFF) isn't saved > properly, and multiple tap interfaces will be created in this > case. Fix this by saving the dynamically allocated tap name > first before reusing the ifr structure. Besides, also make it > possible to support the format string in tap name (e.g. foo%d) > specified by users explicitly. > > Fixes: 791b43e08842 ("net/virtio-user: specify MAC of the tap") > Cc: stable@dpdk.org > > Reported-by: Stephen Hemminger > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_user/vhost_kernel_tap.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > Reviewed-by: Maxime Coquelin