From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [PATCH] net/bonding: stop and
 deactivate slaves when bonding port is stopped
Date: Thu, 23 Aug 2018 14:15:33 +0100
Message-ID: <b02fe55e-6250-9dba-e13f-90080564b854@intel.com>
References: <1533129523-1407-1-git-send-email-radu.nicolau@intel.com>
 <0c16cb66-6ee4-ff2d-6d16-7a3fdd021b0c@intel.com> <11360076.HoYMhSRcrZ@xps>
 <CAG2-GkmSxhU22RTiK+_C3y+x2ECsL_ooEuhEzt5n2tyKbMoAKw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Chas Williams <chas3@att.com>, dev@dpdk.org,
 Declan Doherty <declan.doherty@intel.com>,
 Radu Nicolau <radu.nicolau@intel.com>, stable@dpdk.org
To: Chas Williams <3chas3@gmail.com>, Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <CAG2-GkmSxhU22RTiK+_C3y+x2ECsL_ooEuhEzt5n2tyKbMoAKw@mail.gmail.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/6/2018 4:50 PM, Chas Williams wrote:
> On Sun, Aug 5, 2018 at 5:55 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 
>> 02/08/2018 15:38, Doherty, Declan:
>>> On 01/08/2018 2:18 PM, Radu Nicolau wrote:
>>>> When a bonding port is stopped also stop and deactivate all slaves.
>>>> Otherwise slaves will be still listed as active.
>>>>
>>>> Fixes: 69bce062132b ("net/bonding: do not clear active slave count")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>>>
>>> Acked-by: Declan Doherty <declan.doherty@intel.com>
>>
>> Waiting for opinion from the other bonding maintainer (Chas)
>> who started to review and has some doubts.
>>
> 
> The slaves being listed as active is not a bug.  If the slaves are not
> deactivated, then they should be considered activated.  Previously,
> stopping the bonding PMD just reset the active slave count.  That's
> not the right way to deactivate slaves.  This was fixed by 69bce062132b.
> 
> This patch is new behavior of explicitly deactivating the slaves when
> the bonding PMD is stopped.
> 
> As I mentioned, I think this makes life difficult for those of us using
> an external state machine.  However, that should probably be fixed
> differently then.
> 
> 
>>
>> Chas, please do you agree with Declan's ack?
>>
>>
>>
> Change the Fixes line.

Hi Chas,

Are you OK with the rest of the patch if Fixes line fixed?
If already have a proposed fixes line I can fix it while merging.

Thanks,
ferruh