From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: reduce size of coredump file Date: Wed, 28 Mar 2018 10:48:05 +0200 Message-ID: References: <20180209174017.14644-1-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , "Basierski, SebastianX" To: "Tan, Jianfeng" , "Kulasek, TomaszX" , "yliu@fridaylinux.org" Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 39AFB2BC7 for ; Wed, 28 Mar 2018 10:48:10 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/11/2018 05:34 AM, Tan, Jianfeng wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Kulasek >> Sent: Saturday, February 10, 2018 1:40 AM >> To: yliu@fridaylinux.org >> Cc: dev@dpdk.org; Basierski, SebastianX >> Subject: [dpdk-dev] [PATCH] vhost: reduce size of coredump file >> >> If application coredumps with vhost-user devices connected to it, >> the generated coredump file size is huge. >> >> To limit its size, this patch adds call to madvise() with MADV_DONTDUMP >> on memory regions mapped from the VM. > > As virtqueue is on guest memory, by this patch, the vq information will not be available in the coredump. > > Just wonder if adjusting /proc/pid/coredump_filter can help your case? Yes it helps as by default I never have the guest memory in the coredumps I receive. Maxime > Thanks, > Jianfeng > >> >> Signed-off-by: Sebastian Basierski >> Signed-off-by: Tomasz Kulasek >> --- >> lib/librte_vhost/vhost_user.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c >> index 65ee33919..fc1f1a948 100644 >> --- a/lib/librte_vhost/vhost_user.c >> +++ b/lib/librte_vhost/vhost_user.c >> @@ -723,6 +723,11 @@ vhost_user_set_mem_table(struct virtio_net *dev, >> struct VhostUserMsg *pmsg) >> goto err_mmap; >> } >> >> + if (madvise(mmap_addr, mmap_size, >> MADV_DONTDUMP) != 0) { >> + RTE_LOG(INFO, VHOST_CONFIG, >> + "MADV_DONTDUMP advice setting >> failed.\n"); >> + } >> + >> reg->mmap_addr = mmap_addr; >> reg->mmap_size = mmap_size; >> reg->host_user_addr = (uint64_t)(uintptr_t)mmap_addr + >> -- >> 2.14.1 >