From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-stable] [PATCH v2] examples/qos_sched: fix
 core limit for lower num of lcore
Date: Wed, 19 Jul 2017 13:28:41 +0530
Message-ID: <b0da24e3-7db8-e24f-9798-d818f14876f0@nxp.com>
References: <1500270542-1197-1-git-send-email-hemant.agrawal@nxp.com>
 <1500280631-6634-1-git-send-email-hemant.agrawal@nxp.com>
 <3172790.mMM15UVdKU@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <stable@dpdk.org>, <slawomirx.mrozowicz@intel.com>,
 <cristian.dumitrescu@intel.com>, <dev@dpdk.org>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <3172790.mMM15UVdKU@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/19/2017 10:54 AM, Thomas Monjalon wrote:
> 17/07/2017 11:37, Hemant Agrawal:
>> --- a/examples/qos_sched/main.h
>> +++ b/examples/qos_sched/main.h
>> @@ -69,8 +69,13 @@ extern "C" {
>>  #define BURST_TX_DRAIN_US 100
>>
>>  #ifndef APP_MAX_LCORE
>> +#if (APP_MAX_LCORE > 64)
>>  #define APP_MAX_LCORE 64
>
> If APP_MAX_LCORE is not defined, it cannot be > 64, right?
> Or what am I missing?
>
It should be RTE_MAX_LCORE

>> +#else
>> +#define APP_MAX_LCORE RTE_MAX_LCORE
>> +#endif
>>  #endif
>
>
>