From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v8 2/4] unci: add kernel control path kernel
 module
Date: Fri, 30 Jun 2017 18:02:27 +0100
Message-ID: <b0e44b02-d32c-6db1-adec-a18774609fc9@intel.com>
References: <20170526165228.96919-1-ferruh.yigit@intel.com>
 <20170621110651.75299-1-ferruh.yigit@intel.com>
 <20170621110651.75299-3-ferruh.yigit@intel.com>
 <20170621082323.3c39a2d0@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
 Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 272E37CD0
 for <dev@dpdk.org>; Fri, 30 Jun 2017 19:02:32 +0200 (CEST)
In-Reply-To: <20170621082323.3c39a2d0@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/21/2017 4:23 PM, Stephen Hemminger wrote:
> On Wed, 21 Jun 2017 12:06:49 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> +static struct ethtool_input_buffer {
>> +	int magic;
>> +	void *buffer;
>> +	size_t length;
>> +	struct completion *msg_received;
>> +	int *err;
>> +	u32 in_use;
>> +} ethtool_input_buffer
> 
> Naming in kernel is important. This isn't kernel ethtool, so  it shouldn't be named that.

I have updated naming on v9.

> 
> Having a single instance per system for a control interface means it won't work
> if multiple apps have control channel open or in containers.

This should work for multiple add and interfaces, unci_nl_exec()
serializes the requests, above struct used for output buffer indirection.

I am not sure how to handle requests without serializing them ...

> 
> You should also do policy validation on the netlink message.

I will send a new version with this.

>