From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] mk: fix verbosity zero
Date: Fri, 23 Sep 2016 10:06:05 +0100
Message-ID: <b0e9c72b-4987-58de-4ae3-fa8a7546c0aa@intel.com>
References: <6873211.QDWnoOkD9j@xps13>
 <1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Thomas Monjalon <thomas.monjalon@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C301468EE
 for <dev@dpdk.org>; Fri, 23 Sep 2016 11:06:41 +0200 (CEST)
In-Reply-To: <1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/23/2016 12:42 AM, Thomas Monjalon wrote:
> Verbosity is considered enabled when $V is not empty.
> So V=0 and V=1 are equivalent.
> It is fixed by unsetting V when it is 0.
> 
> A side effect is to fix kernel module compilation verbosity
> which is set to 0 when V is empty.
> 
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  mk/rte.sdkroot.mk | 3 +++
>  mk/rte.vars.mk    | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
> index 55a9d8a..04ad523 100644
> --- a/mk/rte.sdkroot.mk
> +++ b/mk/rte.sdkroot.mk
> @@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory
>  # define Q to '@' or not. $(Q) is used to prefix all shell commands to
>  # be executed silently.
>  Q=@
> +ifeq '$V' '0'
> +override V=
> +endif
>  ifdef V

Why not simply:
-ifdef V
+ifeq ($(V),1)


>  ifeq ("$(origin V)", "command line")
>  Q=
> diff --git a/mk/rte.vars.mk b/mk/rte.vars.mk
> index 28982a5..c240a0e 100644
> --- a/mk/rte.vars.mk
> +++ b/mk/rte.vars.mk
> @@ -46,6 +46,9 @@ endif
>  # define Q to '@' or not. $(Q) is used to prefix all shell commands to
>  # be executed silently.
>  Q=@
> +ifeq '$V' '0'
> +override V=
> +endif
>  ifdef V
>  ifeq ("$(origin V)", "command line")
>  Q=
>