From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 08/25] bnxt: Add support for VLAN filter
 and strip dev_ops
Date: Mon, 29 May 2017 18:43:26 +0100
Message-ID: <b13d0b82-76e7-6d63-5d71-bd253798722d@intel.com>
References: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com>
 <20170526183941.80678-1-ajit.khaparde@broadcom.com>
 <20170526183941.80678-9-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id E15057D6E
 for <dev@dpdk.org>; Mon, 29 May 2017 19:43:28 +0200 (CEST)
In-Reply-To: <20170526183941.80678-9-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/26/2017 7:39 PM, Ajit Khaparde wrote:
> This patch adds VLAN strip and offload callbacks.
> To add a VLAN filter:
>     For each VNIC and each associated filter(s)
>         if VLAN exists:
>             if VLAN matches vlan_id
>                 VLAN filter already exists, just skip and continue
>             else
>                 add a new MAC+VLAN filter
>         else
>             Remove the old MAC only filter
>             Add a new MAC+VLAN filter
> 
> To remove a VLAN filter:
>     For each VNIC and each associated filter(s)
>         if VLAN exists && VLAN matches vlan_id
>             remove the MAC+VLAN filter
>             add a new MAC only filter
>         else
>             VLAN filter doesn't exist, just skip and continue
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

This patch gives a build error [1] which seems fixed in next patch, can
you please move fix to this patch.


[1]
.../drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_del_vlan_filter’:
.../drivers/net/bnxt/bnxt_ethdev.c:1158:8: error: passing argument 2 of
‘bnxt_hwrm_set_filter’ makes pointer from integer without a cast
[-Werror=int-conversion]
        vnic->fw_vnic_id,
        ^~~~
In file included from .../drivers/net/bnxt/bnxt_ethdev.c:46:0:
.../drivers/net/bnxt/bnxt_hwrm.h:51:5: note: expected ‘struct
bnxt_vnic_info *’ but argument is of type ‘uint16_t {aka short unsigned
int}’
 int bnxt_hwrm_set_filter(struct bnxt *bp,
     ^~~~~~~~~~~~~~~~~~~~
.../drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_add_vlan_filter’:
.../drivers/net/bnxt/bnxt_ethdev.c:1232:35: error: passing argument 2 of
‘bnxt_hwrm_set_filter’ makes pointer from integer without a cast
[-Werror=int-conversion]
     rc = bnxt_hwrm_set_filter(bp, vnic->fw_vnic_id,
                                   ^~~~
In file included from .../drivers/net/bnxt/bnxt_ethdev.c:46:0:
.../drivers/net/bnxt/bnxt_hwrm.h:51:5: note: expected ‘struct
bnxt_vnic_info *’ but argument is of type ‘uint16_t {aka short unsigned
int}’
 int bnxt_hwrm_set_filter(struct bnxt *bp,
     ^~~~~~~~~~~~~~~~~~~~