From mboxrd@z Thu Jan  1 00:00:00 1970
From: Remy Horton <remy.horton@intel.com>
Subject: Re: [PATCH] net/sfc: add support for xstats retrieval by
 ID
Date: Wed, 12 Jul 2017 15:18:42 +0100
Message-ID: <b185298f-327d-dc76-14f1-f624814b0e88@intel.com>
References: <1499528715-1510-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Ivan Malov <ivan.malov@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 3466E2C54
 for <dev@dpdk.org>; Wed, 12 Jul 2017 16:18:44 +0200 (CEST)
In-Reply-To: <1499528715-1510-1-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 08/07/2017 16:45, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
[..]

Reviewed-by: Remy Horton <remy.horton@intel.com>


> +	rc = sfc_port_update_mac_stats(sa);
> +	if (rc != 0) {
> +		SFC_ASSERT(rc > 0);
> +		ret = -rc;

sfc_port_update_mac_stats() really ought to be returning -EINVAL or 
-ENOMEM rather than EINVAL/ENOMEM then doing a negation here.

Other than that, code seems OK..