From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] eal: honor IOVA mode for no-huge case Date: Tue, 31 Oct 2017 14:49:27 -0700 Message-ID: References: <1507718028-12943-1-git-send-email-jianfeng.tan@intel.com> <1507718028-12943-2-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: santosh.shukla@caviumnetworks.com, sergio.gonzalez.monroy@intel.com, thomas@monjalon.net To: Jianfeng Tan , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E4C091B231 for ; Tue, 31 Oct 2017 22:49:29 +0100 (CET) In-Reply-To: <1507718028-12943-2-git-send-email-jianfeng.tan@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/2017 3:33 AM, Jianfeng Tan wrote: > With the introduction of IOVA mode, the only blocker to run > with 4KB pages for NICs binding to vfio-pci, is that > RTE_BAD_PHYS_ADDR is not a valid IOVA address. > > We can refine this by using VA as IOVA if it's IOVA mode. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_eal/linuxapp/eal/eal_memory.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c > index 28bca49..187d338 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > @@ -1030,7 +1030,10 @@ rte_eal_hugepage_init(void) > strerror(errno)); > return -1; > } > - mcfg->memseg[0].phys_addr = RTE_BAD_PHYS_ADDR; > + if (rte_eal_iova_mode() == RTE_IOVA_VA) > + mcfg->memseg[0].phys_addr = (uintptr_t)addr; > + else > + mcfg->memseg[0].phys_addr = RTE_BAD_PHYS_ADDR; This breaks KNI which requires physical address. Any idea how to disable RTE_IOVA_VA when KNI used? > mcfg->memseg[0].addr = addr; > mcfg->memseg[0].hugepage_sz = RTE_PGSIZE_4K; > mcfg->memseg[0].len = internal_config.memory; >