From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH] drivers/bus: fill driver reference after NXP probing Date: Fri, 28 Sep 2018 17:57:34 +0530 Message-ID: References: <20180925192259.12249-1-thomas@monjalon.net> <2039580.JQpZYNxiQt@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, hemant.agrawal@nxp.com To: Thomas Monjalon Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50074.outbound.protection.outlook.com [40.107.5.74]) by dpdk.org (Postfix) with ESMTP id 501231B399 for ; Fri, 28 Sep 2018 14:28:01 +0200 (CEST) In-Reply-To: <2039580.JQpZYNxiQt@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thursday 27 September 2018 06:10 PM, Thomas Monjalon wrote: > 26/09/2018 10:12, Shreyansh Jain: >> On Wednesday 26 September 2018 12:52 AM, Thomas Monjalon wrote: >>> The probing functions of NXP buses were missing to set >>> the driver used for successfully probing a device. >>> >>> The NXP driver and the generic rte_driver are now set >>> in the device structures. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >> >> A part of this was already being done in the drv->probe(), though it was >> not complete (dpaa2_dev->driver = dpaa2_drv; was not being done). >> >> --->8---net/dpaa2/dpaa2_ethdev.c-- >> 2008 >> 2009 eth_dev->device = &dpaa2_dev->device; >> 2010 eth_dev->device->driver = &dpaa2_drv->driver; >> 2011 >> --->8--- > > I guess we could remove the driver assignment in NXP drivers, > after this patch applied. > Sent. I have kept fixes reference to your patch.