From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 3/3] kni: set initial value for MTU
Date: Fri, 22 Dec 2017 14:01:45 -0800
Message-ID: <b35fe6c8-3404-df80-6976-9c67e88e2361@intel.com>
References: <1512042367-6361-1-git-send-email-hemant.agrawal@nxp.com>
 <1512042367-6361-3-git-send-email-hemant.agrawal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 906F91B61D
 for <dev@dpdk.org>; Fri, 22 Dec 2017 23:01:47 +0100 (CET)
In-Reply-To: <1512042367-6361-3-git-send-email-hemant.agrawal@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/30/2017 3:46 AM, Hemant Agrawal wrote:
> Configure initial application provided  mtu on the KNI interface.
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

<...>

> @@ -95,6 +95,7 @@ struct rte_kni_conf {
>  	struct rte_pci_addr addr;
>  	struct rte_pci_id id;
>  	char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */
> +	uint16_t mtu;

Same issue here, adding a new field into middle of the public struct.
I think it would be OK to add to the end, but to be sure would you please run
ABI check script (validate-abi.sh) after adding to the end?

Thanks,
ferruh

>  
>  	__extension__
>  	uint8_t force_bind : 1; /* Flag to bind kernel thread */
>