From mboxrd@z Thu Jan 1 00:00:00 1970 From: Remy Horton Subject: Re: [PATCH v1] metrics: fix potential missing NULL termination Date: Tue, 20 Feb 2018 15:32:50 +0000 Message-ID: References: <20180220145001.18442-1-remy.horton@intel.com> <20180220151113.GB14804@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 68B541B040 for ; Tue, 20 Feb 2018 16:32:53 +0100 (CET) In-Reply-To: <20180220151113.GB14804@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/02/2018 15:11, Bruce Richardson wrote: [..] > Again, I think the better fix is to replace strncpy with snprintf which > will guarantee the null termination, unlike strncpy which is nasty that > way. OK, v2 on way..