From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] lib/librte_flow_classify: fix memory leak issue Date: Mon, 22 Jan 2018 14:49:08 +0000 Message-ID: References: <20180122141428.106166-1-jasvinder.singh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: bernard.iremonger@intel.com, john.mcnamara@intel.com To: Jasvinder Singh , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 578E07D30 for ; Mon, 22 Jan 2018 15:49:10 +0100 (CET) In-Reply-To: <20180122141428.106166-1-jasvinder.singh@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2018 2:14 PM, Jasvinder Singh wrote: > Free allocated memory of the rule if not added to the table. > > Coverity issue: 257032 > Fixes: 50bdac5916d9 ("flow_classify: remove table id parameter from API") > > Signed-off-by: Jasvinder Singh Reviewed-by: Ferruh Yigit > --- > lib/librte_flow_classify/rte_flow_classify.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_flow_classify/rte_flow_classify.c b/lib/librte_flow_classify/rte_flow_classify.c > index 6fa6a74..55492a6 100644 > --- a/lib/librte_flow_classify/rte_flow_classify.c > +++ b/lib/librte_flow_classify/rte_flow_classify.c > @@ -560,6 +560,7 @@ rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls, > return rule; > } > } > + free(rule); > return NULL; > } > >