From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 01/10] eal: add shorthand __rte_weak macro
Date: Wed, 3 Oct 2018 17:09:24 +0100
Message-ID: <b3fbbaef-9596-e39a-084f-d1b4dc2f5749@intel.com>
References: <20180803140605.43072-1-keith.wiles@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
To: keith.wiles@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 620B61B11F
 for <dev@dpdk.org>; Wed,  3 Oct 2018 18:09:28 +0200 (CEST)
In-Reply-To: <20180803140605.43072-1-keith.wiles@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/3/2018 3:05 PM, keith.wiles at intel.com (Keith Wiles) wrote:
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> ---
>  lib/librte_eal/common/include/rte_common.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
> index 069c13ec7..2c4535b1a 100644
> --- a/lib/librte_eal/common/include/rte_common.h
> +++ b/lib/librte_eal/common/include/rte_common.h
> @@ -68,6 +68,11 @@ typedef uint16_t unaligned_uint16_t;
>  /******* Macro to mark functions and fields scheduled for removal *****/
>  #define __rte_deprecated	__attribute__((__deprecated__))
>  
> +/**
> + * short definition to mark a function or variable to a weak reference.
> + */
> +#define __rte_weak		__attribute__((__weak__))

Looks good to me.
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Since the change is all mechanical same change in further patches, what do you
think merging this patchset into single patch?