From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH 04/11] lib/librte_net: add ESP header to
 generic flow steering
Date: Fri, 15 Sep 2017 10:21:06 +0530
Message-ID: <b5708a38-2c25-6849-7276-df2bf7fbf73e@nxp.com>
References: <20170914082651.26232-1-akhil.goyal@nxp.com>
 <20170914082651.26232-5-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <declan.doherty@intel.com>, <pablo.de.lara.guarch@intel.com>,
 <radu.nicolau@intel.com>, <borisp@mellanox.com>, <aviadye@mellanox.com>,
 <thomas@monjalon.net>, <sandeep.malik@nxp.com>,
 <jerin.jacob@caviumnetworks.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0047.outbound.protection.outlook.com [104.47.38.47])
 by dpdk.org (Postfix) with ESMTP id 6BE542BBE
 for <dev@dpdk.org>; Fri, 15 Sep 2017 06:51:14 +0200 (CEST)
In-Reply-To: <20170914082651.26232-5-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Boris,

On 9/14/2017 1:56 PM, Akhil Goyal wrote:
> From: Boris Pismenny <borisp@mellanox.com>
>
> The ESP header is required for IPsec crypto actions.
>

> Signed-off-by: Boris Pismenny <borisp@mellanox.com>
> Signed-off-by: Aviad Yehezkel <aviadye@mellanox.com>
> ---
>  doc/api/doxy-api-index.md   |  1 +
>  lib/librte_ether/rte_flow.h | 26 ++++++++++++++++++++
>  lib/librte_net/Makefile     |  2 +-
>  lib/librte_net/rte_esp.h    | 60 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 88 insertions(+), 1 deletion(-)
>  create mode 100644 lib/librte_net/rte_esp.h
>
> diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md
> index a3d39fc..23bafbc 100644
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -107,6 +107,7 @@ The public API headers are grouped by topics:
>    [LPM IPv6 route]     (@ref rte_lpm6.h),
>    [ACL]                (@ref rte_acl.h),
>    [EFD]                (@ref rte_efd.h)
> +  [ESP]                (@ref rte_esp.h)
>
>  - **QoS**:
>    [metering]           (@ref rte_meter.h),
> diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
> index bba6169..ea08af6 100644
> --- a/lib/librte_ether/rte_flow.h
> +++ b/lib/librte_ether/rte_flow.h
> @@ -50,6 +50,7 @@
>  #include <rte_tcp.h>
>  #include <rte_udp.h>
>  #include <rte_byteorder.h>
> +#include <rte_esp.h>
>
>  #ifdef __cplusplus
>  extern "C" {
> @@ -309,6 +310,13 @@ enum rte_flow_item_type {
>  	 * See struct rte_flow_item_fuzzy.
>  	 */
>  	RTE_FLOW_ITEM_TYPE_FUZZY,
> +
> +	/**
> +	 * Matches a ESP header.
> +	 *
> +	 * See struct rte_flow_item_esp.
> +	 */
> +	RTE_FLOW_ITEM_TYPE_ESP,
>  };

will you please also add changes for rte_flow documentation in prog_guide?