From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hemant Agrawal Subject: Re: [PATCH 2/2] mk: clean up static link with DPAA libraries Date: Fri, 23 Feb 2018 11:55:33 +0530 Message-ID: References: <1519329652.2458.5.camel@suse.de> <20180222225308.16972-1-thomas@monjalon.net> <20180222225308.16972-2-thomas@monjalon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon , mvarlese@suse.de Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01hn0232.outbound.protection.outlook.com [104.47.1.232]) by dpdk.org (Postfix) with ESMTP id E665A293C for ; Fri, 23 Feb 2018 07:25:52 +0100 (CET) In-Reply-To: <20180222225308.16972-2-thomas@monjalon.net> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, On 2/23/2018 4:23 AM, Thomas Monjalon wrote: > The bus and mempool dependencies should be declared after the PMD > libraries needing them. > > Moreover there is no need to disable the PMDs at the Makefile level, > in case the dependencies are not met. > Such dependencies should be handled at configuration time. > > The other side effect of this clean-up is to take into account > the mempool option CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.app.mk | 20 ++++---------------- > 1 file changed, 4 insertions(+), 16 deletions(-) This patch looks good, however I think we (NXP) need to also set some dependency check in makefile to avoid dpaaX PMD compilations, if bus is not available. I am working on a patch for the same. Regards, Hemant > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 3eb41d176..b71a71663 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -127,11 +127,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lrte_pmd_bnx2x -lz > _LDLIBS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += -lrte_pmd_bnxt > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond > _LDLIBS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += -lrte_pmd_cxgbe > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += -lrte_bus_dpaa > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += -lrte_mempool_dpaa > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_pmd_dpaa > -endif > _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_pmd_dpaa2 > _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000 > _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena > @@ -204,16 +200,8 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -lrte_pmd_armv8 > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_ARMV8_CRYPTO) += -L$(ARMV8_CRYPTO_LIB_PATH) -larmv8_crypto > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_MRVL_CRYPTO) += -L$(LIBMUSDK_PATH)/lib -lrte_pmd_mrvl_crypto -lmusdk > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER) += -lrte_pmd_crypto_scheduler > -ifeq ($(CONFIG_RTE_LIBRTE_FSLMC_BUS),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_mempool_dpaa2 > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_bus_fslmc > -endif # CONFIG_RTE_LIBRTE_FSLMC_BUS > - > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA_BUS),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += -lrte_bus_dpaa > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA_SEC) += -lrte_pmd_dpaa_sec > -endif # CONFIG_RTE_LIBRTE_DPAA_BUS > > endif # CONFIG_RTE_LIBRTE_CRYPTODEV > > @@ -232,10 +220,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_RAWDEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SKELETON_RAWDEV) += -lrte_pmd_skeleton_rawdev > endif # CONFIG_RTE_LIBRTE_RAWDEV > > -ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_PMD),y) > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_bus_fslmc > -_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_PMD) += -lrte_mempool_dpaa2 > -endif # CONFIG_RTE_LIBRTE_DPAA2_PMD > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_BUS) += -lrte_bus_dpaa > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_MEMPOOL) += -lrte_mempool_dpaa > +_LDLIBS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += -lrte_bus_fslmc > +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) += -lrte_mempool_dpaa2 > > endif # !CONFIG_RTE_BUILD_SHARED_LIBS > >