From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v2 2/2] vhost: remove pending IOTLB entry if
 IOTLB MISS request sending failed
Date: Mon, 29 Jan 2018 17:31:53 +0100
Message-ID: <b5dd2ca2-4e3a-dc4c-6bd3-512c2d6e57ac@redhat.com>
References: <20180129151347.23640-1-maxime.coquelin@redhat.com>
 <20180129151347.23640-3-maxime.coquelin@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: stable@dpdk.org
To: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org,
 jfreimann@redhat.com, jianfeng.tan@intel.com
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180129151347.23640-3-maxime.coquelin@redhat.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 01/29/2018 04:13 PM, Maxime Coquelin wrote:
> @@ -52,8 +54,13 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
>   		 */
>   		vhost_user_iotlb_rd_unlock(vq);
>   
> -		vhost_user_iotlb_pending_insert(vq, iova + tmp_size, perm);
> -		vhost_user_iotlb_miss(dev, iova + tmp_size, perm);
> +		vhost_user_iotlb_pending_insert(vq, iova, perm);
> +		if (vhost_user_iotlb_miss(dev, iova, perm)) {
> +			RTE_LOG(ERR, VHOST_CONFIG,
> +					"Failed to send IOTLB miss request for IOVA %lx\n",
> +					iova + tmp_size);

Oops, the correct value is "iova", not "iova + tmp_size"

I just posted v3 fixing it.

Maxime