From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 2/2] net/pcap: duplicate code consolidation
Date: Wed, 20 Jun 2018 18:41:00 +0100
Message-ID: <b77f7cb2-a73f-030f-c7c4-8cff0f0fb70e@intel.com>
References: <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>
 <1529419046-95906-2-git-send-email-ido@cgstowernetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: ido goshen <ido@cgstowernetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D54D81B524
 for <dev@dpdk.org>; Wed, 20 Jun 2018 19:41:02 +0200 (CEST)
In-Reply-To: <1529419046-95906-2-git-send-email-ido@cgstowernetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/19/2018 3:37 PM, ido goshen wrote:
> Signed-off-by: ido goshen <ido@cgstowernetworks.com>

<...>

>  /*
> + * Opens a NIC for reading packets from it
> + */
> +static inline int
> +open_rx_iface(const char *key, const char *value, void *extra_args)
> +{
> +	return open_iface(key, value, extra_args);
> +}
> +
> +/*
>   * Opens a NIC for writing packets to it
>   */
>  static int
>  open_tx_iface(const char *key, const char *value, void *extra_args)
>  {
> -	const char *iface = value;
> -	struct pmd_devargs *tx = extra_args;
> -	pcap_t *pcap;
> -
> -	if (tx->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)
> -		return -1;
> -	if (open_single_iface(iface, &pcap) < 0)
> -		return -1;
> -	tx->queue[tx->num_of_queue].pcap = pcap;
> -	tx->queue[tx->num_of_queue].name = iface;
> -	tx->queue[tx->num_of_queue].type = key;
> -	tx->num_of_queue++;
> -
> -	return 0;
> +	return open_iface(key, value, extra_args);
>  }
>  
>  static struct rte_vdev_driver pmd_pcap_drv;
> 

Is there a reason to keep open_tx_iface() and open_rx_iface(), they both are
wrapper to open_iface().
Why not use open_iface() directly as callback function?