From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/tap: fix indentation in flow file Date: Thu, 5 Oct 2017 22:33:40 +0100 Message-ID: References: <1507042556-9839-1-git-send-email-matan@mellanox.com> <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Pascal Mazon , Matan Azrad Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8B3621B1F9 for ; Thu, 5 Oct 2017 23:33:43 +0200 (CEST) In-Reply-To: <28a38c08-efac-3a4f-24d8-028dd35749db@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/2017 6:26 PM, Ferruh Yigit wrote: > On 10/4/2017 9:15 AM, Pascal Mazon wrote: >> Hi, >> >> I'm surprised there's only one place in the file with indent problem, >> but I'm ok with the patch otherwise. >> >> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >> patch 2/2, right? > > I wasn't sure about getting the patch that fixes only syntax in one place. > Good to have proper syntax but a commit for this looked like overkill to > me. So I was suggesting keep it as it is and fix syntax when that piece > of code updated later. > > But you are the maintainer of the driver, if you have strong opinion to > get it, sure I can. What has been fixed is still in next-net, so I can squash this. <...> >>>> Missed 4 spaces were added after break if line. >>>> >>>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") >>> What do you think fixing this when that code has been touched next time? >>> >>>> Signed-off-by: Matan Azrad Squashed into relevant commit in next-net, thanks.