From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v6 2/3] app/testpmd: add command for queue setup Date: Fri, 20 Apr 2018 12:29:59 +0100 Message-ID: References: <20180212045314.171616-1-qi.z.zhang@intel.com> <20180408024221.228450-1-qi.z.zhang@intel.com> <20180408024221.228450-3-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, beilei.xing@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com To: Qi Zhang , thomas@monjalon.net, konstantin.ananyev@intel.com Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id F01FA7F0C for ; Fri, 20 Apr 2018 13:30:02 +0200 (CEST) In-Reply-To: <20180408024221.228450-3-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/8/2018 3:42 AM, Qi Zhang wrote: > Add new command to setup queue: > queue setup (rx|tx) (port_id) (queue_idx) (ring_size) (offloads) My almost classic comment for testpmd: Do we need a new high level command "queue setup" for this. Can't we extend existing port/queue setting commands for the sake of the usability. Each feature is trying to add its new command in its new syntax what suits to author. And why both (ring_size) and (offloads) set in same command, as far as I can see you can't ignore them, so to set ring_size I should know offloads for queue too, they don't look too related why setting together in same command. Isn't there any other command to set ring_size? I would be surprised if there is no. And there are a few new command for setting/getting offloads. Can't we re-use them?