From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4] app/testpmd: enable the heavyweight mode
 TCP/IPv4 GRO
Date: Sat, 7 Oct 2017 00:26:22 +0100
Message-ID: <b7fe8e66-085b-83da-aa32-055ab82b7a6e@intel.com>
References: <1504420216-3258-1-git-send-email-jiayu.hu@intel.com>
 <1506407202-29843-1-git-send-email-jiayu.hu@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A2965D1@shsmsx102.ccr.corp.intel.com>
 <b003fe26-033b-8f28-65a7-b0924893ad01@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yao, Lei A" <lei.a.yao@intel.com>, "Hu, Jiayu" <jiayu.hu@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 05D9F1B1AB
 for <dev@dpdk.org>; Sat,  7 Oct 2017 01:26:31 +0200 (CEST)
In-Reply-To: <b003fe26-033b-8f28-65a7-b0924893ad01@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/7/2017 12:04 AM, Ferruh Yigit wrote:
> On 9/27/2017 8:23 AM, Yao, Lei A wrote:
> <...>
> 
>>> The GRO library provides two modes to reassemble packets. Currently, the
>>> csum forwarding engine has supported to use the lightweight mode to
>>> reassemble TCP/IPv4 packets. This patch introduces the heavyweight mode
>>> for TCP/IPv4 GRO in the csum forwarding engine.
>>>
>>> With the command "set port <port_id> gro on|off", users can enable
>>> TCP/IPv4 GRO for a given port. With the command "set gro flush <cycles>",
>>> users can determine when the GROed TCP/IPv4 packets are flushed from
>>> reassembly tables. With the command "show port <port_id> gro", users can
>>> display GRO configuration.
>>>
>>> The GRO library doesn't re-calculate checksums for merged packets. If
>>> users want the merged packets to have correct IP and TCP checksums,
>>> please select HW IP checksum calculation and HW TCP checksum calculation
>>> for the port which the merged packets are transmitted to.
>>>
>>> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
>> Tested-by: Yao Lei<lei.a.yao@intel.com>
> 
> Applied to dpdk-next-net/master, thanks.

nope, removing it out back.

There are "uint8_t port_id" usage a few places, now port_id is uint16_t,
this is new in the repo.

For testpmd you can prefer "portid_t" storage type as well.

Can you please send a new version?