From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] net/e1000: always enable receive and transmit Date: Tue, 18 Jul 2017 12:50:11 +0100 Message-ID: References: <1500319133-16815-1-git-send-email-ciwillia@brocade.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: wenzhuo.lu@intel.com To: "Charles (Chas) Williams" , dev@dpdk.org Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 36F993253 for ; Tue, 18 Jul 2017 13:50:17 +0200 (CEST) In-Reply-To: <1500319133-16815-1-git-send-email-ciwillia@brocade.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/17/2017 8:18 PM, Charles (Chas) Williams wrote: > The transmit and receive controller state machines are only enabled after > receiving an interrupt and the link status is now valid. If an adapter > is being used in conjuction with NC-SI, network controller sideband > interface, the adapter may never get a link state change interrupt since > the adapter's PHY is always link up and never changes state. > > To fix this, always enable and disable the transmit and receive with > .dev_start and .dev_stop. This is a better match for what is typically > done with the other PMD's. Since we may never get an interrupt to check > the link state, we also poll once at the end of .dev_start to get the > current link status. Hi Charles, Is this patch target 17.08-rc2? Since this is not a fix, can this be postponed to 17.11? > > Signed-off-by: Chas Williams <...>