From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/5] net/szedata2: refactor ibuf and obuf names Date: Mon, 29 May 2017 13:40:57 +0100 Message-ID: References: <1495821956-5050-1-git-send-email-vido@cesnet.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Matej Vido , dev@dpdk.org Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 117ED7CE1 for ; Mon, 29 May 2017 14:40:59 +0200 (CEST) In-Reply-To: <1495821956-5050-1-git-send-email-vido@cesnet.cz> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/26/2017 7:05 PM, Matej Vido wrote: > Signed-off-by: Matej Vido Hi Matej, Overall patchset looks good to me, but can you please provide a little more information in commit logs, please check comments on patches. For this patch, it seems refactor naming is removing "cgmii", what is the reason of this, is cgmii no more true or adding different interface? Thanks, ferruh > --- > drivers/net/szedata2/rte_eth_szedata2.c | 80 +++++++++++++++--------------- > drivers/net/szedata2/rte_eth_szedata2.h | 48 +++++++++--------- > 2 files changed, 64 insertions(+), 64 deletions(-) <...>