From mboxrd@z Thu Jan  1 00:00:00 1970
From: Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [PATCH] crypto/dpaa2_sec: update driver name string
Date: Thu, 6 Jul 2017 14:24:16 +0530
Message-ID: <b932fc81-f899-e8c4-4f19-a7bb0d6663b8@nxp.com>
References: <20170705162142.11170-1-akhil.goyal@nxp.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CBD6F66@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam01on0058.outbound.protection.outlook.com [104.47.32.58])
 by dpdk.org (Postfix) with ESMTP id 90D532C8
 for <dev@dpdk.org>; Thu,  6 Jul 2017 10:54:24 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBD6F66@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/6/2017 1:19 PM, De Lara Guarch, Pablo wrote:
> Hi Akhil,
> 
>> -----Original Message-----
>> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
>> Sent: Wednesday, July 5, 2017 5:22 PM
>> To: dev@dpdk.org
>> Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
>> Subject: [PATCH] crypto/dpaa2_sec: update driver name string
>>
>> while registering driver to dpaa2, hard coded string is used.
>> It is now updated as per the latest changes in string name.
>>
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>> ---
>>   drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> index 769a139..b0794f5 100644
>> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
>> @@ -2008,5 +2008,5 @@ static struct rte_dpaa2_driver
>> rte_dpaa2_sec_driver = {
>>   	.remove = cryptodev_dpaa2_sec_remove,
>>   };
>>
>> -RTE_PMD_REGISTER_DPAA2(dpaa2_sec_pmd, rte_dpaa2_sec_driver);
>> +RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD,
>> rte_dpaa2_sec_driver);
>>   RTE_PMD_REGISTER_CRYPTO_DRIVER(rte_dpaa2_sec_driver,
>> cryptodev_driver_id);
>> --
>> 2.9.3
> 
> Now that the name is internal, and since this not used to create a vdev and therefore,
> it is not used publicly, could we modify the name from "crypto_dpaa2_sec_pmd" to
> "crypto_dpaa2_sec", to follow the crypto driver name convention (crypto_<pmd_name>?
> 
> Thanks,
> Pablo
> 
> 
yes no issues.