From mboxrd@z Thu Jan  1 00:00:00 1970
From: "David Harton (dharton)" <dharton@cisco.com>
Subject: Re: [PATCH] ixgbe: add counter to track sw tx packets
Date: Tue, 29 Aug 2017 19:20:17 +0000
Message-ID: <b9a95b002af84c669baab650572b7bc0@XCH-RCD-016.cisco.com>
References: <20170829155056.12563-1-dharton@cisco.com>
 <20170829114254.7b563118@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73])
 by dpdk.org (Postfix) with ESMTP id A5CE211D4
 for <dev@dpdk.org>; Tue, 29 Aug 2017 21:20:22 +0200 (CEST)
In-Reply-To: <20170829114254.7b563118@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, August 29, 2017 2:43 PM
> To: David Harton (dharton) <dharton@cisco.com>
> Cc: konstantin.ananyev@intel.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets
>=20
> On Tue, 29 Aug 2017 11:50:56 -0400
> David Harton <dharton@cisco.com> wrote:
>=20
> > +	if (n < (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS))
> > +		return (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS);
>=20
> Please don't use BSD style.
> Return does not need parenthesis.

Sure.