From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Subject: Re: [PATCH v2] eal: Support running as unprivileged user
Date: Wed, 18 Jan 2017 17:05:29 +0000
Message-ID: <b9cef700-7c54-7d28-8396-46953afab48e@intel.com>
References: <20170103223033.26313-1-benjamin.walker@intel.com>
 <20170103225600.51310-1-benjamin.walker@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
To: Ben Walker <benjamin.walker@intel.com>, dev@dpdk.org,
 Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 78395FABB
 for <dev@dpdk.org>; Wed, 18 Jan 2017 18:05:32 +0100 (CET)
In-Reply-To: <20170103225600.51310-1-benjamin.walker@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 03/01/2017 22:56, Ben Walker wrote:
> For Linux kernel 4.0 and newer, the ability to obtain
> physical page frame numbers for unprivileged users from
> /proc/self/pagemap was removed. Instead, when an IOMMU
> is present, simply choose our own DMA addresses instead.
>
> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
> @@ -255,6 +257,22 @@ find_physaddrs(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
>   }
>   
>   /*
> + * For each hugepage in hugepg_tbl, fill the physaddr value sequentially.
> + */
> +static int
> +set_physaddrs(struct hugepage_file *hugepg_tbl, struct hugepage_info *hpi)
> +{
> +	unsigned int i;
> +	phys_addr_t addr = 0;
> +
> +	for (i = 0; i < hpi->num_pages[0]; i++) {
> +		hugepg_tbl[i].physaddr = addr;
> +		addr += hugepg_tbl[i].size;
> +	}
> +	return 0;
> +}
> +

Sorry for late catch, but when having multiple hugepage sizes, both 
would be mapped from address 0.
I thin making the var static should be enough.
Also I would prefer some randomness on the start address instead of 
always 0.

Thanks,
Sergio