From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3 08/21] net/virtio: implement receive path for packed queues Date: Fri, 6 Apr 2018 09:51:32 +0200 Message-ID: References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-9-jfreimann@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com To: Jens Freimann , dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 87CFE1CE4F for ; Fri, 6 Apr 2018 09:51:39 +0200 (CEST) In-Reply-To: <20180405101031.26468-9-jfreimann@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jens, On 04/05/2018 12:10 PM, Jens Freimann wrote: > From: Yuanhan Liu > > Implement the receive part here. No support for mergeable buffers yet. > > Signed-off-by: Jens Freimann > Signed-off-by: Yuanhan Liu > --- > drivers/net/virtio/virtio_ethdev.c | 10 ++- > drivers/net/virtio/virtio_ethdev.h | 2 + > drivers/net/virtio/virtio_rxtx.c | 137 ++++++++++++++++++++++++++++++++++++- > 3 files changed, 146 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 089a161ac..dc220c743 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1315,10 +1315,15 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev) > { > struct virtio_hw *hw = eth_dev->data->dev_private; > > - if (hw->use_simple_rx) { > + /* workarount for packed vqs which don't support mrg_rxbuf at this point */ I don't think you need such workarounds, just advertise the packed ring layout feature once full support is introduced. Also I'm not cleat what the workaround is needed here, as you set to virtio_recv_pkts_packed whatever mrg is on or not.