From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FFAC433B4 for ; Mon, 26 Apr 2021 13:35:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 3FDA261168 for ; Mon, 26 Apr 2021 13:35:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FDA261168 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 491C441110; Mon, 26 Apr 2021 15:35:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C290340140 for ; Mon, 26 Apr 2021 15:35:31 +0200 (CEST) IronPort-SDR: PZRuhU+j4E+5OFKzFwKfQ7q/H811Ljtgkv1VhY0HB8Fvmt6W2ylYyKnRcURyUY7vCVOK/LLYXD psHWMtlQZkgw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="196446721" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="196446721" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 06:35:29 -0700 IronPort-SDR: caIQZwCylDbZ5ipgCYAnnwXjLrRVqJH65gWofnfNus/7Hj6Ge04Cn7wB8mZfsA/r5tVxo5nPrJ v3p7FHlc0EcQ== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="402926738" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.240.23]) ([10.213.240.23]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 06:35:28 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619063789-60922-1-git-send-email-humin29@huawei.com> <1619063789-60922-4-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 26 Apr 2021 14:35:15 +0100 MIME-Version: 1.0 In-Reply-To: <1619063789-60922-4-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/3] kni: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/22/2021 4:56 AM, Min Hu (Connor) wrote: > Return value 'rte_kni_init' of a function is not checked. If > it fails, error handling (logging and return) should be done. > > This patch fixed it. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) With the patch title update, Reviewed-by: Ferruh Yigit