From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 2/7] net/ixgbe/base: remove a compiler warning Date: Wed, 11 Jan 2017 15:38:15 +0000 Message-ID: References: <1484063146-15796-1-git-send-email-wei.dai@intel.com> <1484063146-15796-3-git-send-email-wei.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: helin.zhang@intel.com, konstantin.ananyev@intel.com To: Wei Dai , dev@dpdk.org Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 77361F614 for ; Wed, 11 Jan 2017 16:38:18 +0100 (CET) In-Reply-To: <1484063146-15796-3-git-send-email-wei.dai@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/10/2017 3:45 PM, Wei Dai wrote: > This patch fixes a compiler warning. I guess compiler warning is because of "mac->led_link_act = i;", since led_link_act is 8bits.. But can you please add the compile warning here, to make it more clear to understand what is the issue. > > Signed-off-by: Wei Dai > --- > drivers/net/ixgbe/base/ixgbe_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c > index 18bb18c..0dd33b8 100644 > --- a/drivers/net/ixgbe/base/ixgbe_common.c > +++ b/drivers/net/ixgbe/base/ixgbe_common.c > @@ -1150,7 +1150,7 @@ s32 ixgbe_init_led_link_act_generic(struct ixgbe_hw *hw) > { > struct ixgbe_mac_info *mac = &hw->mac; > u32 led_reg, led_mode; > - u16 i; > + u8 i; > > led_reg = IXGBE_READ_REG(hw, IXGBE_LEDCTL); > >