From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v5] ethdev: allow returning error on VLAN offload ops Date: Wed, 25 Oct 2017 15:13:05 -0700 Message-ID: References: <20170901023628.21308-1-dharton@cisco.com> <20171025030101.43269-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, David Harton To: John McNamara , Allain Legacy , Matt Peters , Stephen Hurd , Ajit Khaparde , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , John Daley , Nelson Escobar , Jing Chen , Jingjing Wu , Beilei Xing , Konstantin Ananyev , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Alejandro Lucero , Rasesh Mody , Harish Patil , Shahed Shaikh , Yuanhan Liu Received: from mga02.intel.com (unknown [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B7D6B1BA1A for ; Thu, 26 Oct 2017 00:13:08 +0200 (CEST) In-Reply-To: <20171025030101.43269-1-ferruh.yigit@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/24/2017 8:01 PM, Ferruh Yigit wrote: > From: David Harton > > Some devices may not support or fail setting VLAN offload > configuration based on dynamic circumstances so the > vlan_offload_set_t vector is modified to return an int so > the caller can determine success or not. > > rte_eth_dev_set_vlan_offload is updated to return the > value provided by the vector when called along with restoring > the original offload configs on failure. > > Existing vlan_offload_set_t vectors are modified to return > an int. Majority of cases return 0 but a few that actually > can fail now return their failure codes. > > Finally, a vlan_offload_set_t vector is added to virtio > to facilitate dynamically turning VLAN strip on or off. > > Signed-off-by: David Harton > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.