From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v4 0/2] fix pcap handlers for secondary Date: Fri, 16 Nov 2018 14:54:56 +0000 Message-ID: References: <20181105210823.38757-1-qi.z.zhang@intel.com> <20181115013742.117776-1-qi.z.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: thomas@monjalon.net, dev@dpdk.org, xueqin.lin@intel.com To: Qi Zhang Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EA0BD4CB1 for ; Fri, 16 Nov 2018 15:55:01 +0100 (CET) In-Reply-To: <20181115013742.117776-1-qi.z.zhang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/15/2018 1:37 AM, Qi Zhang wrote: > Private vdev was the way previously, when pdump developed, now with > shared device mode on virtual devices, pcap data path in secondary is > not working. > > When secondary adds a virtual device, related data transferred to > primary and primary creates the device and shares device back with > secondary. When pcap device created in primary, pcap handlers (pointers) > are process local and they are not valid for secondary process. This > breaks secondary. > > So we can't directly share the pcap handlers, but need to create a new > set of handlers for secondary, that's what we done in this patch. > > Also so we use `rte_eth_dev->process_private` to store pcap handlers > separately for each process, so a handler in one process will not be > closed or overwritten by another process unexpectedly. > > v4: > - rx_burst/tx_burst should use the local pcap handler directly. > - add missing devargs memcpy for sharing to secondary process. > > v3: > - fix hardcoded queue number. > - use process_private. > > v2: > - fix init issue when try to dump to an iface. > > Qi Zhang (2): > net/pcap: move pcap handler to process private > net/pcap: enable data path for secondary For series, Reviewed-by: Ferruh Yigit