From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 0/6] net/sfc: convert to the new offload API Date: Wed, 17 Jan 2018 16:55:04 +0000 Message-ID: References: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Thomas Monjalon , Shahaf Shuler To: Andrew Rybchenko , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 78DB11B1A2 for ; Wed, 17 Jan 2018 17:55:07 +0100 (CET) In-Reply-To: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > May be it is too late to suggest a new API functions to ethdev, > but hopefully if the idea is accepted, it could be applied in the > current release cycle since these functions are trivial. Agreed, I think they are OK to get in even late. > > I'm not sure that rte_ethdev_version.map is updated correctly > since EXPERIMENTAL tag is present and I don't understand how it > should be handled. > > In general for the transition period from old offload API to the > new one it would be useful to convert Tx offloads to/from txq_flags > in rte_eth_dev_info_get() for default_txconf and > rte_eth_tx_queue_info_get(). Unfortunately it was lost during > new offload API patches review. However, it would require testing > for all network PMDs and we decided to follow more conservative > approach and kept code to fill in txq_flags which should be simply > removed when txq_flags are removed. > > Cc: Thomas Monjalon > Cc: Ferruh Yigit > Cc: Shahaf Shuler > > Ivan Malov (6): > ethdev: add a function to look up Rx offload names > ethdev: add a function to look up Tx offload names > net/sfc: factor out function to report Rx capabilities > net/sfc: convert to the new Rx offload API > net/sfc: factor out function to report Tx capabilities > net/sfc: convert to the new Tx offload API Series Reviewed-by: Ferruh Yigit