From mboxrd@z Thu Jan 1 00:00:00 1970 From: "John Daley (johndale)" Subject: Re: [RFC 4/4] enic: remove anscillary assignment Date: Tue, 10 Oct 2017 17:32:06 +0000 Message-ID: References: <20170926185329.2776-1-aconole@redhat.com> <20170926185329.2776-5-aconole@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Aaron Conole , "dev@dpdk.org" Return-path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 9339B1B30F for ; Tue, 10 Oct 2017 19:32:08 +0200 (CEST) In-Reply-To: <20170926185329.2776-5-aconole@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaron Conole > Sent: Tuesday, September 26, 2017 11:53 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment >=20 > The assignment at initialization is overwritten immediately. Drop the > assignment. >=20 > Signed-off-by: Aaron Conole > --- > drivers/net/enic/base/vnic_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/enic/base/vnic_dev.c > b/drivers/net/enic/base/vnic_dev.c > index a4b7f4b..932667f 100644 > --- a/drivers/net/enic/base/vnic_dev.c > +++ b/drivers/net/enic/base/vnic_dev.c > @@ -272,7 +272,7 @@ int vnic_dev_alloc_desc_ring(struct vnic_dev *vdev, > __attribute__((unused)) unsigned int socket_id, > char *z_name) > { > - void *alloc_addr =3D NULL; > + void *alloc_addr; > dma_addr_t alloc_pa =3D 0; >=20 > vnic_dev_desc_ring_size(ring, desc_count, desc_size); > -- > 2.9.5 Reviewed-by: John Daley Thanks, Johnd