From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH v4 3/6] bus: introduce device level DMA
 memory mapping
Date: Wed, 13 Mar 2019 11:47:29 +0000
Message-ID: <befc128b-b97a-6300-ea8a-785471a76fd9@intel.com>
References: <cover.1551793527.git.shahafs@mellanox.com>
 <1698312.TEgN2QzQvo@xps>
 <AM0PR0502MB3795D92D8DB68B66A5823F28C34A0@AM0PR0502MB3795.eurprd05.prod.outlook.com>
 <1907286.xmCKSEcAjO@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Yongseok Koh <yskoh@mellanox.com>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>
To: Thomas Monjalon <thomas@monjalon.net>, Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 0B4EF4C8E
 for <dev@dpdk.org>; Wed, 13 Mar 2019 12:47:31 +0100 (CET)
In-Reply-To: <1907286.xmCKSEcAjO@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 13-Mar-19 11:19 AM, Thomas Monjalon wrote:
> 13/03/2019 12:12, Shahaf Shuler:
>> From: Thomas Monjalon <thomas@monjalon.net>
>>>> +/**
>>>> + * Device level DMA map function.
>>>> + * After a successful call, the memory segment will be mapped to the
>>>> + * given device.
>>>> + *
>>>> + * @note: Memory must be registered in advance using rte_extmem_*
>>> APIs.
>>>
>>> Could we make more explicit that this function is part of the "external
>>> memory API"?
>>
>> How do you suggest?
> 
> There could be an explicit comment.
> 
>> This function belongs to rte_dev therefore the rte_dev prefix. better rte_dev_extmem_dma_map ?
> 
> Not sure about the prefix. Anatoly?
> 

IMO this is a dev API. The fact that its purpose is to use it with 
extmem is coincidental.

-- 
Thanks,
Anatoly