From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 1/2] net/mlx4: split the definitions to
 the header file
Date: Mon, 6 Mar 2017 09:24:22 +0000
Message-ID: <bf72e684-18b3-41ff-8f12-61dc0161d7c0@intel.com>
References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com>
 <74798f347a5b1fad28037b713ad83048c227a2ca.1487770570.git.vasilyf@mellanox.com>
 <1964838c-9f28-1680-705d-148bcf0e816c@intel.com>
 <AM5PR0501MB24818154E2D03F5AFC767A26DB530@AM5PR0501MB2481.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 Neil Horman <nhorman@tuxdriver.com>
To: Vasily Philipov <vasilyf@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 3B78A108A
 for <dev@dpdk.org>; Mon,  6 Mar 2017 10:24:26 +0100 (CET)
In-Reply-To: <AM5PR0501MB24818154E2D03F5AFC767A26DB530@AM5PR0501MB2481.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/23/2017 10:44 AM, Vasily Philipov wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Wednesday, February 22, 2017 21:05
>> To: Vasily Philipov <vasilyf@mellanox.com>; dev@dpdk.org
>> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Nélio Laranjeiro
>> <nelio.laranjeiro@6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx4: split the definitions to the
>> header file
>>
>> On 2/22/2017 1:42 PM, Vasily Philipov wrote:
>>> Make some structs/defines visible from different source files by
>>> placing them into mlx4.h header.
>>>
>>> Signed-off-by: Vasily Philipov <vasilyf@mellanox.com>
>>> ---
>>>  drivers/net/mlx4/mlx4.c | 183
>>> ++--------------------------------------------
>>>  drivers/net/mlx4/mlx4.h | 187
>>> +++++++++++++++++++++++++++++++++++++++++++++++-
>>>  2 files changed, 189 insertions(+), 181 deletions(-)
>>>
>>> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index
>>> 79efaaa..82ccac8 100644
>>> --- a/drivers/net/mlx4/mlx4.c
>>> +++ b/drivers/net/mlx4/mlx4.c
>>> @@ -1,8 +1,8 @@
>>>  /*-
>>>   *   BSD LICENSE
>>>   *
>>> - *   Copyright 2012-2015 6WIND S.A.
>>> - *   Copyright 2012 Mellanox.
>>> + *   Copyright 2012-2017 6WIND S.A.
>>> + *   Copyright 2012-2017 Mellanox.
>>
>> Can someone knowledgeable about Copyright help please?
>>
>> What is the year field in Copyright line for?
>> And above change updates Copyright from 2012 to 2012-2017, is this correct?
>>
> 
> The year line was changes in order to show when the file was changed the last time...

I see, but I don't know if the year field is for last updated date
marker, specially when there are multiple copyright holders.

Overall I don't know why second date is required at all, assuming first
date shows the start date of the work and sets the copyright coverage date.

A comment from who knows more about these issues is welcome.

Thanks,
ferruh