From: "Brandes, Shai" <shaibran@amazon.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Schmeilin, Evgeny" <evgenys@amazon.com>,
"Beider, Ron" <rbeider@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Atrash, Wajeeh" <atrwajee@amazon.com>
Subject: RE: [PATCH] net/ena: remove unused abort macro
Date: Wed, 9 Oct 2024 12:08:19 +0000 [thread overview]
Message-ID: <bfcb7fa8619947369f54c5d93bd2bb48@amazon.com> (raw)
In-Reply-To: <20241009114921.1231790-1-thomas@monjalon.net>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, October 9, 2024 2:49 PM
> To: dev@dpdk.org
> Cc: Brandes, Shai <shaibran@amazon.com>; Schmeilin, Evgeny
> <evgenys@amazon.com>; Beider, Ron <rbeider@amazon.com>; Bernstein,
> Amit <amitbern@amazon.com>; Atrash, Wajeeh <atrwajee@amazon.com>
> Subject: [EXTERNAL] [PATCH] net/ena: remove unused abort macro
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> The function abort() should be forbidden for drivers and libs.
> It is not used in ENA, but the rule is enfocred by removing the macro.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/net/ena/base/ena_plat_dpdk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/ena/base/ena_plat_dpdk.h
> b/drivers/net/ena/base/ena_plat_dpdk.h
> index 21b96113c7..a41a4e4506 100644
> --- a/drivers/net/ena/base/ena_plat_dpdk.h
> +++ b/drivers/net/ena/base/ena_plat_dpdk.h
> @@ -63,8 +63,6 @@ typedef uint64_t dma_addr_t;
>
> #define ENA_CDESC_RING_SIZE_ALIGNMENT (1 << 12) /* 4K */
>
> -#define ENA_ABORT() abort()
> -
> #define ENA_MSLEEP(x) rte_delay_us_sleep(x * 1000) #define
> ENA_USLEEP(x) rte_delay_us_sleep(x) #define ENA_UDELAY(x)
> rte_delay_us_block(x)
> --
> 2.46.0
[Brandes, Shai] Thanks Thomas, we verified this in our CI.
Acked-by: Shai Brandes <shaibran@amazon.com>
next prev parent reply other threads:[~2024-10-09 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:49 [PATCH] net/ena: remove unused abort macro Thomas Monjalon
2024-10-09 12:08 ` Brandes, Shai [this message]
2024-10-09 12:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfcb7fa8619947369f54c5d93bd2bb48@amazon.com \
--to=shaibran@amazon.com \
--cc=amitbern@amazon.com \
--cc=atrwajee@amazon.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=rbeider@amazon.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).