From mboxrd@z Thu Jan  1 00:00:00 1970
From: bugzilla@dpdk.org
Subject: [Bug 121] In ixgbe_tx_free_bufs function the variable
 free on stack is used before initialization
Date: Fri, 07 Dec 2018 14:55:03 +0000
Message-ID: <bug-121-3@http.bugs.dpdk.org/>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

https://bugs.dpdk.org/show_bug.cgi?id=3D121

            Bug ID: 121
           Summary: In ixgbe_tx_free_bufs function the variable free on
                    stack is used before initialization
           Product: DPDK
           Version: unspecified
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: core
          Assignee: dev@dpdk.org
          Reporter: valentin.radulescu@enea.com
  Target Milestone: ---

static __rte_always_inline int
ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq)
{
....
    struct rte_mbuf *m, *free[RTE_IXGBE_TX_MAX_FREE_BUF_SZ];
....

       if (nb_free >=3D RTE_IXGBE_TX_MAX_FREE_BUF_SZ ||
            (nb_free > 0 && m->pool !=3D free[0]->pool)) { <---free[0] is f=
rom
the stack
            rte_mempool_put_bulk(free[0]->pool,
                         (void **)free, nb_free);
            nb_free =3D 0;
        }

        free[nb_free++] =3D m;  <-- free is set later
}

--=20
You are receiving this mail because:
You are the assignee for the bug.=