From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA4E8C433C1 for ; Mon, 29 Mar 2021 09:57:21 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 53F0661554 for ; Mon, 29 Mar 2021 09:57:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53F0661554 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=dpdk.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58EF240151; Mon, 29 Mar 2021 11:57:20 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id CE37240042 for ; Mon, 29 Mar 2021 11:57:19 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id B0E88A0547; Mon, 29 Mar 2021 11:57:19 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Mon, 29 Mar 2021 09:57:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: other X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: major X-Bugzilla-Who: michallinuxstuff@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 668] DPDK power governor fails if base_frequency is not opened X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://bugs.dpdk.org/show_bug.cgi?id=3D668 Bug ID: 668 Summary: DPDK power governor fails if base_frequency is not opened Product: DPDK Version: 20.11 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: major Priority: Normal Component: other Assignee: dev@dpdk.org Reporter: michallinuxstuff@gmail.com Target Milestone: --- DPDK fails to initialize pstate cpufreq in case base_frequency is missing f= rom sysfs under given cpu. This is a bit problematic now since this particular = attr exists only under specific conditions: active intel_pstate + HWP supported = by the cpu. Also, from the commit itself (4db9587bbf) it looks like this was p= ut in place by accident since the part which accepts missing base_frequency (a= nd which sets it to 0) still exists, i.e.: snprintf(fullpath_base, sizeof(fullpath_base), POWER_SYSFILE_BASE_FREQ, pi->lcore_id); f_base =3D fopen(fullpath_base, "r");=20 FOPEN_OR_ERR_RET(f_base, -1); /* <- point of failure */ if (f_base =3D=3D NULL) { /* No sysfs base_frequency, that's OK, continue without */ base_ratio =3D 0; Initially noticed under https://github.com/spdk/spdk/issues/1859. Any feedback on the matter would be appreciate. :) --=20 You are receiving this mail because: You are the assignee for the bug.=