From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42659C4338F for ; Wed, 4 Aug 2021 17:03:30 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id BA70160F22 for ; Wed, 4 Aug 2021 17:03:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA70160F22 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=dpdk.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD18E41252; Wed, 4 Aug 2021 19:03:28 +0200 (CEST) Received: from inbox.dpdk.org (inbox.dpdk.org [95.142.172.178]) by mails.dpdk.org (Postfix) with ESMTP id BB1F641250 for ; Wed, 4 Aug 2021 19:03:27 +0200 (CEST) Received: by inbox.dpdk.org (Postfix, from userid 33) id AB9E2A0C40; Wed, 4 Aug 2021 19:03:27 +0200 (CEST) From: bugzilla@dpdk.org To: dev@dpdk.org Date: Wed, 04 Aug 2021 17:03:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DPDK X-Bugzilla-Component: ethdev X-Bugzilla-Version: 20.11 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dg573847474@gmail.com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: dev@dpdk.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter target_milestone Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.dpdk.org/ Auto-Submitted: auto-generated X-Auto-Response-Suppress: All MIME-Version: 1.0 Subject: [dpdk-dev] [Bug 777] Potential error(e.g., resource leak, deadlock) due to the unreleased lock pdata->i2c_mutex X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" https://bugs.dpdk.org/show_bug.cgi?id=3D777 Bug ID: 777 Summary: Potential error(e.g., resource leak, deadlock) due to the unreleased lock pdata->i2c_mutex Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component: ethdev Assignee: dev@dpdk.org Reporter: dg573847474@gmail.com Target Milestone: --- source: drivers/net/axgbe/axgbe_i2c.c Hi, developers, thank you for your checking. The lock &pdata->i2c_mutex may= not be correctly released if the ret=3D=3D1 and control flow goes to these two = branches listed below. Finally, the method returns with the unreleased lock. The fix= is to insert pthread_mutex_unlock(&pdata->i2c_mutex); before returning. static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op) { ...; pthread_mutex_lock(&pdata->i2c_mutex); ret =3D axgbe_i2c_disable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to disable i2c master\n"); return ret; // the method returns with unreleased lock } ...; ret =3D axgbe_i2c_enable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to enable i2c master\n"); return ret; // the method returns with unreleased lock } ...; } --=20 You are receiving this mail because: You are the assignee for the bug.=