From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCHv2] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases Date: Thu, 12 Apr 2018 13:05:12 +0100 Message-ID: References: <20180402120619.30404-1-nhorman@tuxdriver.com> <20180412111640.8977-1-nhorman@tuxdriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Monjalon , Ferruh Yigit To: Neil Horman , dev@dpdk.org Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 346951BB68 for ; Thu, 12 Apr 2018 14:05:16 +0200 (CEST) In-Reply-To: <20180412111640.8977-1-nhorman@tuxdriver.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12-Apr-18 12:16 PM, Neil Horman wrote: > https://dpdk.org/tracker/show_bug.cgi?id=18 > > Indicated that several mmap call sites in the [linux|bsd]app eal code > set fd that was not -1 in their calls while using MAP_ANONYMOUS. While > probably not a huge deal, the man page does say the fd should be -1 for > portability, as some implementations don't ignore fd as they should for > MAP_ANONYMOUS. > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: Ferruh Yigit > > --- > Change notes > > v2) Rebased to HEAD again to adjust for patches that landed ahead of > this > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly