From mboxrd@z Thu Jan 1 00:00:00 1970 From: "David Harton (dharton)" Subject: Re: [PATCH] i40e: fix i40e_validate_mac_addr to permit multicast addresses Date: Fri, 8 Sep 2017 12:51:58 +0000 Message-ID: References: <20170822222146.36912-1-dharton@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" To: Ferruh Yigit , "jingjing.wu@intel.com" , "beilei.xing@intel.com" Return-path: Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) by dpdk.org (Postfix) with ESMTP id 09D922E8B for ; Fri, 8 Sep 2017 14:52:00 +0200 (CEST) Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" SGkgSmluZ2ppbmcvQmVpbGVpLA0KDQpBIGtpbmQgcmVtaW5kZXIgdG8gcmV2aWV3IHRoZSBwYXRj aCBhbmQgdGhlIGRpc2N1c3Npb24gYmV0d2VlbiANCkZlcnJ1aCBhbmQgbXlzZWxmLg0KDQpUaGFu a3MsDQpEYXZlDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogRGF2aWQg SGFydG9uIChkaGFydG9uKQ0KPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gRnJv bTogRmVycnVoIFlpZ2l0IFttYWlsdG86ZmVycnVoLnlpZ2l0QGludGVsLmNvbV0NCj4gPg0KPiA+ IE9uIDgvMjIvMjAxNyAxMToyMSBQTSwgRGF2aWQgSGFydG9uIHdyb3RlOg0KPiA+ID4gVGhlIGk0 MGUgbWFpbnRhaW5zIGEgc2luZ2xlIE1BQyBmaWx0ZXIgdGFibGUgZm9yIGJvdGggdW5pY2FzdCBh bmQNCj4gPiA+IG11bHRpY2FzdCBhZGRyZXNzZXMuICBUaGUgaTQwZV92YWxpZGF0ZV9tYWNfYWRk ciBmdW5jdGlvbiB3YXMNCj4gPiA+IHByZXZlbnRpbmcgbXVsdGljYXN0IGFkZHJlc3NlcyBmcm9t IGJlaW5nIGFkZGVkIHRvIHRoZSB0YWJsZSB2aWENCj4gPiA+IGk0MGV2Zl9hZGRfbWFjX2FkZHIu ICBGaXhlZCB0aGUgaXNzdWUgYnkgcmVtb3ZpbmcgdGhlIG11bHRpY2FzdA0KPiA+ID4gYWRkcmVz cyBjaGVjayBpbiBpNDBlX3ZhbGlkYXRlX21hY19hZGRyLg0KPiA+ID4NCj4gPiA+IFNpZ25lZC1v ZmYtYnk6IERhdmlkIEhhcnRvbiA8ZGhhcnRvbkBjaXNjby5jb20+DQo+ID4gPiAtLS0NCj4gPiA+ ICBkcml2ZXJzL25ldC9pNDBlL2Jhc2UvaTQwZV9jb21tb24uYyB8IDEyICsrKysrLS0tLS0tLQ0K PiA+ID4gIGRyaXZlcnMvbmV0L2k0MGUvaTQwZV9ldGhkZXYuYyAgICAgIHwgIDMgKystDQo+ID4g PiAgMiBmaWxlcyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pDQo+ID4g Pg0KPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2k0MGUvYmFzZS9pNDBlX2NvbW1vbi5j DQo+ID4gPiBiL2RyaXZlcnMvbmV0L2k0MGUvYmFzZS9pNDBlX2NvbW1vbi5jDQo+ID4gPiBpbmRl eCA5MDBkMzc5Li45Nzc5ODU0IDEwMDY0NA0KPiA+ID4gLS0tIGEvZHJpdmVycy9uZXQvaTQwZS9i YXNlL2k0MGVfY29tbW9uLmMNCj4gPiA+ICsrKyBiL2RyaXZlcnMvbmV0L2k0MGUvYmFzZS9pNDBl X2NvbW1vbi5jDQo+ID4gPiBAQCAtOTY5LDEwICs5NjksMTAgQEAgc3RydWN0IGk0MGVfcnhfcHR5 cGVfZGVjb2RlZA0KPiA+ID4gaTQwZV9wdHlwZV9sb29rdXBbXSA9IHsNCj4gPiA+DQo+ID4gPg0K PiA+ID4gIC8qKg0KPiA+ID4gLSAqIGk0MGVfdmFsaWRhdGVfbWFjX2FkZHIgLSBWYWxpZGF0ZSB1 bmljYXN0IE1BQyBhZGRyZXNzDQo+ID4gPiArICogaTQwZV92YWxpZGF0ZV9tYWNfYWRkciAtIFZh bGlkYXRlIE1BQyBhZGRyZXNzDQo+ID4gPiAgICogQG1hY19hZGRyOiBwb2ludGVyIHRvIE1BQyBh ZGRyZXNzDQo+ID4gPiAgICoNCj4gPiA+IC0gKiBUZXN0cyBhIE1BQyBhZGRyZXNzIHRvIGVuc3Vy ZSBpdCBpcyBhIHZhbGlkIEluZGl2aWR1YWwgQWRkcmVzcw0KPiA+ID4gKyAqIFRlc3RzIGEgTUFD IGFkZHJlc3MgdG8gZW5zdXJlIGl0IGlzIGEgdmFsaWQgQWRkcmVzcw0KPiA+ID4gICAqKi8NCj4g PiA+ICBlbnVtIGk0MGVfc3RhdHVzX2NvZGUgaTQwZV92YWxpZGF0ZV9tYWNfYWRkcih1OCAqbWFj X2FkZHIpICB7IEBADQo+ID4gPiAtOTgwLDEzICs5ODAsMTEgQEAgZW51bSBpNDBlX3N0YXR1c19j b2RlIGk0MGVfdmFsaWRhdGVfbWFjX2FkZHIodTgNCj4gPiA+ICptYWNfYWRkcikNCj4gPiA+DQo+ ID4gPiAgCURFQlVHRlVOQygiaTQwZV92YWxpZGF0ZV9tYWNfYWRkciIpOw0KPiA+ID4NCj4gPiA+ IC0JLyogQnJvYWRjYXN0IGFkZHJlc3NlcyBBUkUgbXVsdGljYXN0IGFkZHJlc3Nlcw0KPiA+ID4g LQkgKiBNYWtlIHN1cmUgaXQgaXMgbm90IGEgbXVsdGljYXN0IGFkZHJlc3MNCj4gPiA+ICsJLyoN Cj4gPiA+ICAJICogUmVqZWN0IHRoZSB6ZXJvIGFkZHJlc3MNCj4gPiA+ICAJICovDQo+ID4gPiAt CWlmIChJNDBFX0lTX01VTFRJQ0FTVChtYWNfYWRkcikgfHwNCj4gPiA+IC0JICAgIChtYWNfYWRk clswXSA9PSAwICYmIG1hY19hZGRyWzFdID09IDAgJiYgbWFjX2FkZHJbMl0gPT0gMCAmJg0KPiA+ ID4gLQkgICAgICBtYWNfYWRkclszXSA9PSAwICYmIG1hY19hZGRyWzRdID09IDAgJiYgbWFjX2Fk ZHJbNV0gPT0gMCkpDQo+ID4gPiArCWlmIChtYWNfYWRkclswXSA9PSAwICYmIG1hY19hZGRyWzFd ID09IDAgJiYgbWFjX2FkZHJbMl0gPT0gMCAmJg0KPiA+ID4gKwkgICAgbWFjX2FkZHJbM10gPT0g MCAmJiBtYWNfYWRkcls0XSA9PSAwICYmIG1hY19hZGRyWzVdID09IDApDQo+ID4gPiAgCQlzdGF0 dXMgPSBJNDBFX0VSUl9JTlZBTElEX01BQ19BRERSOw0KPiA+ID4NCj4gPiA+ICAJcmV0dXJuIHN0 YXR1czsNCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9pNDBlL2k0MGVfZXRoZGV2LmMN Cj4gPiA+IGIvZHJpdmVycy9uZXQvaTQwZS9pNDBlX2V0aGRldi5jIGluZGV4IDVmMjZlMjQuLjAw YjYwODIgMTAwNjQ0DQo+ID4gPiAtLS0gYS9kcml2ZXJzL25ldC9pNDBlL2k0MGVfZXRoZGV2LmMN Cj4gPiA+ICsrKyBiL2RyaXZlcnMvbmV0L2k0MGUvaTQwZV9ldGhkZXYuYw0KPiA+ID4gQEAgLTEx OTksNyArMTE5OSw4IEBAIGV0aF9pNDBlX2Rldl9pbml0KHN0cnVjdCBydGVfZXRoX2RldiAqZGV2 KQ0KPiA+ID4NCj4gPiA+ICAJLyogR2V0IGFuZCBjaGVjayB0aGUgbWFjIGFkZHJlc3MgKi8NCj4g PiA+ICAJaTQwZV9nZXRfbWFjX2FkZHIoaHcsIGh3LT5tYWMuYWRkcik7DQo+ID4gPiAtCWlmIChp NDBlX3ZhbGlkYXRlX21hY19hZGRyKGh3LT5tYWMuYWRkcikgIT0gSTQwRV9TVUNDRVNTKSB7DQo+ ID4gPiArCWlmIChpNDBlX3ZhbGlkYXRlX21hY19hZGRyKGh3LT5tYWMuYWRkcikgIT0gSTQwRV9T VUNDRVNTIHx8DQo+ID4gPiArCSAgICBJNDBFX0lTX01VTFRJQ0FTVChody0+bWFjLmFkZHIpKSB7 DQo+ID4NCj4gPiBBcyBmYXIgYXMgSSBjYW4gc2VlIHRoaXMgaXMgdG8gc2V0IFBGIHBlcm1hbmVu dCBtYWMgYWRkcmVzcyBkdXJpbmcNCj4gPiBpbml0KCksDQo+ID4gaTQwZV9tYWNhZGRyX2FkZCgp IGNhbiBiZSB1c2VkIHRvIHNldCBtdWx0aWNhc3QgYWRkcmVzcyBmaWx0ZXJzLg0KPiA+IFdoeSBk byB5b3Ugd2FudCB0byBzZXQgbXVsdGljYXN0IGFkZHJlc3MgYXMgbWFjIHBlcm1hbmVudCBhZGRy ZXNzPw0KPiA+DQo+ID4gQW55IGNoYW5jZSB0aGF0IHlvdSB3YW50IHRvIHVwZGF0ZSBpNDBldmZf YWRkX21hY19hZGRyKCkgdG8gbGV0DQo+ID4gbXVsdGljYXN0IGFkZHJlc3Nlcz8NCj4gDQo+IE5v LiAgSSdtIHByZXNlcnZpbmcgdGhlIGV4aXN0aW5nIGJlaGF2aW9yIGhlcmUuICBUaGUgcHJldmlv dXMgY2FsbCB1c2VkIHRvDQo+IGVuc3VyZSB0aGF0IHRoZSBwZXJtYW5lbnQgbWFjIGFkZHJlc3Mg aGVyZSB3YXMgYm90aCBub24tbnVsbCBhbmQgbm90IGENCj4gbXVsdGktY2FzdCBhZGRyZXNzLg0K PiANCj4gU2luY2UgSSByZW1vdmVkIHRoZSBtdWx0aSBjYXN0IGNoZWNrIGZyb20gaTQwZV92YWxp ZGF0ZV9tYWNfYWRkcigpIEkgYWRkZWQNCj4gdGhlIG11bHRpY2FzdCBjaGVjayBoZXJlLiAgSWYg Im5vdCB2YWxpZCIgb3IgYSBtdWx0aWNhc3QgYWRkcmVzcyBmYWlsLg0KPiANCj4gUmVnYXJkcywN Cj4gRGF2ZQ0KPiANCj4gPg0KPiA+ID4gIAkJUE1EX0lOSVRfTE9HKEVSUiwgIm1hYyBhZGRyZXNz IGlzIG5vdCB2YWxpZCIpOw0KPiA+ID4gIAkJcmV0ID0gLUVJTzsNCj4gPiA+ICAJCWdvdG8gZXJy X2dldF9tYWNfYWRkcjsNCj4gPiA+DQoNCg==