From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH v5 2/2] ci: Introduce travis builds for github repositories Date: Wed, 27 Feb 2019 16:06:49 +0000 Message-ID: References: <20190206221308.22349-1-msantana@redhat.com> <2766343.Bn91GvS4A1@xps> <2641130.kfz5e2tDNj@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Michael Santana , dev@dpdk.org, Bruce Richardson , Honnappa Nagarahalli To: Aaron Conole , Thomas Monjalon Return-path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by dpdk.org (Postfix) with ESMTP id 82C255688 for ; Wed, 27 Feb 2019 17:06:51 +0100 (CET) Received: by mail-wm1-f53.google.com with SMTP id j125so6104035wmj.1 for ; Wed, 27 Feb 2019 08:06:51 -0800 (PST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2019-02-27 at 10:53 -0500, Aaron Conole wrote: > Thomas Monjalon writes: >=20 > > 27/02/2019 15:35, Aaron Conole: > > > Thomas Monjalon writes: > > > > 07/02/2019 23:01, Michael Santana: > > > > > +python3.5 -m pip install --upgrade meson --user > > > >=20 > > > > Which distributions have python3.5? > > > > It looks very specific. > > >=20 > > > I agree, could probably just be python3 we need to check and see > > > if we > > > can just use that. > > >=20 > > > But, we did need the upgrade. > > >=20 > > > Travis environment comes up with ubuntu 14.04, which includes > > > python3.4, > > > and the requisite version of meson needs python3.5 or higher. > >=20 > > It could be a python --version check then? >=20 > Well, I don't know what the purpose of the version check would > be. We > can tailor the environments. Just need to pass the right > information, > that's all. I think we'll make it look nicer, though. We can do any > environment specific fix ups in the prepare scripts, which I think > makes > sense. Then the build script can be a bit more generic. Travis supports Ubuntu 16.04 images now, which have python 3.5, I'd suggest to just use them (dist: xenial) so you can skip all the checks and the manual installations. --=20 Kind regards, Luca Boccassi