From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shreyansh Jain Subject: Re: [PATCH v6 1/5] iFPGA: Add Intel FPGA BUS Library Date: Wed, 2 May 2018 18:44:27 +0530 Message-ID: References: <1521553556-62982-1-git-send-email-rosen.xu@intel.com> <1524735793-37302-1-git-send-email-rosen.xu@intel.com> <1524735793-37302-2-git-send-email-rosen.xu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: declan.doherty@intel.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, tianfei.zhang@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com To: "Xu, Rosen" , dev@dpdk.org Return-path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-ve1eur03hn0201.outbound.protection.outlook.com [104.47.9.201]) by dpdk.org (Postfix) with ESMTP id AF6FC23C for ; Wed, 2 May 2018 14:58:17 +0200 (CEST) In-Reply-To: <1524735793-37302-2-git-send-email-rosen.xu@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thursday 26 April 2018 03:13 PM, Xu, Rosen wrote: > From: Rosen Xu > > Defined FPGA-BUS for Acceleration Drivers of AFUs > 1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process, > probe Intel FPGA Rawdev Driver. > 2. AFU Scan(2nd Scan) bind DPDK driver to FPGA Partial-Bitstream. > This scan is trigged by hotplug of IFPGA Rawdev probe, in this scan > the AFUs will be created and their drivers are also probed. > > Signed-off-by: Rosen Xu > Signed-off-by: Figo zhang > --- > config/common_base | 5 + > drivers/bus/Makefile | 1 + > drivers/bus/ifpga/Makefile | 32 ++ > drivers/bus/ifpga/ifpga_bus.c | 503 ++++++++++++++++++++++++++++ > drivers/bus/ifpga/ifpga_common.c | 88 +++++ > drivers/bus/ifpga/ifpga_common.h | 18 + > drivers/bus/ifpga/ifpga_logs.h | 31 ++ > drivers/bus/ifpga/meson.build | 6 + > drivers/bus/ifpga/rte_bus_ifpga.h | 168 ++++++++++ > drivers/bus/ifpga/rte_bus_ifpga_version.map | 10 + > drivers/bus/meson.build | 2 +- > mk/rte.app.mk | 2 + > 12 files changed, 865 insertions(+), 1 deletion(-) > create mode 100644 drivers/bus/ifpga/Makefile > create mode 100644 drivers/bus/ifpga/ifpga_bus.c > create mode 100644 drivers/bus/ifpga/ifpga_common.c > create mode 100644 drivers/bus/ifpga/ifpga_common.h > create mode 100644 drivers/bus/ifpga/ifpga_logs.h > create mode 100644 drivers/bus/ifpga/meson.build > create mode 100644 drivers/bus/ifpga/rte_bus_ifpga.h > create mode 100644 drivers/bus/ifpga/rte_bus_ifpga_version.map > Hello Rosen, While compiling this series with meson, I found following warnings: --->8--- 3d/1& [shreyansh:~/build/DPDK/00_dpdk/ifpga-build]↥ master(6)+* ± ninja [335/949] Compiling C object 'drivers/tmp_rte_bus_ifpga@sta/bus_ifpga_ifpga_bus.c.o'. ../drivers/bus/ifpga/ifpga_bus.c: In function ‘rte_ifpga_scan’: ../drivers/bus/ifpga/ifpga_bus.c:217:2: warning: ‘rte_devargs_next’ is deprecated: Symbol is not yet part of stable ABI [-Wdeprecated-declarations] RTE_EAL_DEVARGS_FOREACH("ifpga", devargs) { ^~~~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/bus/ifpga/ifpga_bus.c:24:0: ../lib/librte_eal/common/include/rte_devargs.h:262:1: note: declared here rte_devargs_next(const char *busname, const struct rte_devargs *start); ^~~~~~~~~~~~~~~~ ../drivers/bus/ifpga/ifpga_bus.c:217:2: warning: ‘rte_devargs_next’ is deprecated: Symbol is not yet part of stable ABI [-Wdeprecated-declarations] RTE_EAL_DEVARGS_FOREACH("ifpga", devargs) { ^~~~~~~~~~~~~~~~~~~~~~~ In file included from ../drivers/bus/ifpga/ifpga_bus.c:24:0: ../lib/librte_eal/common/include/rte_devargs.h:262:1: note: declared here rte_devargs_next(const char *busname, const struct rte_devargs *start); ^~~~~~~~~~~~~~~~ ../drivers/bus/ifpga/ifpga_bus.c: In function ‘rte_ifpga_unplug’: ../drivers/bus/ifpga/ifpga_bus.c:419:2: warning: ‘rte_devargs_remove’ is deprecated: Symbol is not yet part of stable ABI [-Wdeprecated-declarations] rte_devargs_remove(devargs->bus->name, devargs->name); ^~~~~~~~~~~~~~~~~~ In file included from ../drivers/bus/ifpga/ifpga_bus.c:24:0: ../lib/librte_eal/common/include/rte_devargs.h:195:5: note: declared here int rte_devargs_remove(const char *busname, ^~~~~~~~~~~~~~~~~~ ../drivers/bus/ifpga/ifpga_bus.c: At top level: cc1: warning: unrecognized command line option ‘-W --->8--- My meson configuration is: --->8--- 3d/1& [shreyansh:~/build/DPDK/00_dpdk]↥ master(6)+* 130 ± ~/.local/bin/meson ifpga-build The Meson build system Version: 0.44.0 Source dir: /home/shreyansh/build/DPDK/00_dpdk Build dir: /home/shreyansh/build/DPDK/00_dpdk/ifpga-build Build type: native build Project name: DPDK Native C compiler: ccache cc (gcc 7.2.0) Build machine cpu family: x86_64 Build machine cpu: x86_64 Library numa found: YES Has header "numaif.h": YES ... --->8--- Can you please look into this? - Shreyansh