From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 2/2] net/mlx5: fix PMD specific parameters
 defaults
Date: Wed, 19 Apr 2017 13:25:02 +0100
Message-ID: <c0fcb05c-3f3c-b0a6-9a5a-4c5b77f53cf7@intel.com>
References: <20170416074640.171390-1-shahafs@mellanox.com>
 <20170418102228.145971-1-shahafs@mellanox.com>
 <20170418102228.145971-2-shahafs@mellanox.com>
 <a510b444-e315-89ec-8eec-a6238358f339@intel.com>
 <AM4PR05MB1505C64D79FAEB559D64BAB9C3180@AM4PR05MB1505.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id CD72437A6
 for <dev@dpdk.org>; Wed, 19 Apr 2017 14:25:04 +0200 (CEST)
In-Reply-To: <AM4PR05MB1505C64D79FAEB559D64BAB9C3180@AM4PR05MB1505.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/19/2017 12:32 PM, Shahaf Shuler wrote:
> Wednesday, April 19, 2017 1:57 PM, Ferruh Yigit:
>> On 4/18/2017 11:22 AM, Shahaf Shuler wrote:
>>> With the Enhanced multi packet send addition, the defaults were made
>>> in order to get the maximum out of the box performance.
>>> Features like tso, don't use the enhanced send, however the defaults
>>> are still valid. This cause Tx queue creation to fail.
>>>
>>> Fixes: aea00c008140 ("net/mlx5: add hardware TSO support")
>>
>> Can you please confirm the Fixes line, the code modified below added with
>> commit [1], and above commit (correct one is: 3f13f8c23a7c) doesn't touch
>> those lines?
> 
> Well I guess it can be either. 
> The commit Fixes TSO because [1] caused TSO to fail on some cases.
> The commit Fixes multi-packet send since it is the one which caused the fault.
> 
> Since you pointed that out, I guess other will follow your logic as well. So let's take you suggestion.

Does it make sense to add both?

> Do you need me to post a v3? 

If you confirm, I can update while applying, not a new patch required.

> 
>>
>> [1]
>> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for
>> ConnectX-5")