From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: KNI broken again with 4.9 kernel
Date: Thu, 15 Dec 2016 10:25:10 +0000
Message-ID: <c1714adb-6f14-0c4c-b130-3d9588d55842@intel.com>
References: <20161214154049.698de2e8@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 5262710A7
 for <dev@dpdk.org>; Thu, 15 Dec 2016 11:25:13 +0100 (CET)
In-Reply-To: <20161214154049.698de2e8@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

I can't reproduce the error, I think it is not broken, that issue should
be already fixed with commit [1].



On 12/14/2016 11:40 PM, Stephen Hemminger wrote:
> /build/lib/librte_eal/linuxapp/kni/igb_main.c:2317:21: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>   .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
>                      ^~~~~~~~~~~~~~~~~~~

Thanks for the report, not everyone is working with latest kernel, so
these reports are useful.

> 
> I am sure Ferruh Yigit will fix it.

I think I already did J, please check the commit [1], it is merged in
v16.11, can you please double check the DPDK version.


[1]
 commit 6445198f802d993c73f4b246353b2ceb2dfafc32
 Refs: v16.11-rc1-2-g6445198
 Author:     Ferruh Yigit <ferruh.yigit@intel.com>
 AuthorDate: Mon Oct 17 11:23:14 2016 +0100
 Commit:     Thomas Monjalon <thomas.monjalon@6wind.com>
 CommitDate: Tue Oct 25 16:20:43 2016 +0200

     kni: fix build with kernel 4.9

     compile error:
       CC [M]  .../lib/librte_eal/linuxapp/kni/igb_main.o
     .../lib/librte_eal/linuxapp/kni/igb_main.c:2317:21:
     error: initialization from incompatible pointer type
             [-Werror=incompatible-pointer-types]
       .ndo_set_vf_vlan = igb_ndo_set_vf_vlan,
                          ^~~~~~~~~~~~~~~~~~~

     Linux kernel 4.9 updates API for ndo_set_vf_vlan:
     Linux: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad
support")

     Use new API for Linux kernels >= 4.9

     Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
     Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>


<...>
I will reply questions with a different subject...