RE: [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP

[Kishore Padmanabha <kishore.padmanabha@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>

-----Original Message-----
From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Sent: Friday, February 27, 2026 3:00 PM
To: dev@dpdk.org
Cc: kishore.padmanabha@broadcom.com; Keegan Freyhof
<keegan.freyhof@broadcom.com>; stable@dpdk.org
Subject: [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP

From: Keegan Freyhof <keegan.freyhof@broadcom.com>

Fix compile warnings seen when using clang with the -Wcomma flag in the
bnxt ULP driver code by replacing commas with semicolons.

Bugzilla ID: 1807
Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")
Cc: stable@dpdk.org

Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique
<Mohammad-Shuab.Siddique@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index 38cb5c8b31..bc347de202 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -1296,10 +1296,10 @@ ulp_tf_global_cfg_update(struct bnxt *bp,
 	struct tf *tfp;

 	/* Initialize the params */
-	parms.dir = dir,
-	parms.type = type,
-	parms.offset = offset,
-	parms.config = (uint8_t *)&global_cfg,
+	parms.dir = dir;
+	parms.type = type;
+	parms.offset = offset;
+	parms.config = (uint8_t *)&global_cfg;
 	parms.config_sz_in_bytes = sizeof(global_cfg);

 	tfp = bnxt_ulp_bp_tfp_get(bp, BNXT_ULP_SESSION_TYPE_DEFAULT);
--
2.47.3

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5493 bytes --]