* [PATCH] net/bnxt: fix clang wcomma warnings in ULP
@ 2026-02-27 19:42 Mohammad Shuab Siddique
2026-02-27 19:53 ` [PATCH v2] " Mohammad Shuab Siddique
0 siblings, 1 reply; 5+ messages in thread
From: Mohammad Shuab Siddique @ 2026-02-27 19:42 UTC (permalink / raw)
To: dev; +Cc: kishore.padmanabha, Keegan Freyhof, stable
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Fix compile warnings seen when using clang with the -Wcomma flag
in the bnxt ULP driver code by replacing commas with semicolons.
Bugzilla ID: 1807
Fixes: dd0191d5e70("net/bnxt/tf_ulp: support Thor2 ULP layer")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <Mohammad-Shuab.Siddique@broadcom.com>
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index 38cb5c8b31..bc347de202 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -1296,10 +1296,10 @@ ulp_tf_global_cfg_update(struct bnxt *bp,
struct tf *tfp;
/* Initialize the params */
- parms.dir = dir,
- parms.type = type,
- parms.offset = offset,
- parms.config = (uint8_t *)&global_cfg,
+ parms.dir = dir;
+ parms.type = type;
+ parms.offset = offset;
+ parms.config = (uint8_t *)&global_cfg;
parms.config_sz_in_bytes = sizeof(global_cfg);
tfp = bnxt_ulp_bp_tfp_get(bp, BNXT_ULP_SESSION_TYPE_DEFAULT);
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2] net/bnxt: fix clang wcomma warnings in ULP
2026-02-27 19:42 [PATCH] net/bnxt: fix clang wcomma warnings in ULP Mohammad Shuab Siddique
@ 2026-02-27 19:53 ` Mohammad Shuab Siddique
2026-02-27 20:00 ` [PATCH v3] " Mohammad Shuab Siddique
0 siblings, 1 reply; 5+ messages in thread
From: Mohammad Shuab Siddique @ 2026-02-27 19:53 UTC (permalink / raw)
To: dev; +Cc: Kishore.Padmananbha, Keegan Freyhof, stable
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Fix compile warnings seen when using clang with the -Wcomma flag
in the bnxt ULP driver code by replacing commas with semicolons.
Bugzilla ID: 1807
Fixes: dd0191d5e70 ("net/bnxt/tf_ulp: support Thor2 ULP layer")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <Mohammad-Shuab.Siddique@broadcom.com>
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index 38cb5c8b31..bc347de202 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -1296,10 +1296,10 @@ ulp_tf_global_cfg_update(struct bnxt *bp,
struct tf *tfp;
/* Initialize the params */
- parms.dir = dir,
- parms.type = type,
- parms.offset = offset,
- parms.config = (uint8_t *)&global_cfg,
+ parms.dir = dir;
+ parms.type = type;
+ parms.offset = offset;
+ parms.config = (uint8_t *)&global_cfg;
parms.config_sz_in_bytes = sizeof(global_cfg);
tfp = bnxt_ulp_bp_tfp_get(bp, BNXT_ULP_SESSION_TYPE_DEFAULT);
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP
2026-02-27 19:53 ` [PATCH v2] " Mohammad Shuab Siddique
@ 2026-02-27 20:00 ` Mohammad Shuab Siddique
2026-03-03 18:02 ` Kishore Padmanabha
0 siblings, 1 reply; 5+ messages in thread
From: Mohammad Shuab Siddique @ 2026-02-27 20:00 UTC (permalink / raw)
To: dev; +Cc: kishore.padmanabha, Keegan Freyhof, stable
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Fix compile warnings seen when using clang with the -Wcomma flag
in the bnxt ULP driver code by replacing commas with semicolons.
Bugzilla ID: 1807
Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique <Mohammad-Shuab.Siddique@broadcom.com>
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index 38cb5c8b31..bc347de202 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -1296,10 +1296,10 @@ ulp_tf_global_cfg_update(struct bnxt *bp,
struct tf *tfp;
/* Initialize the params */
- parms.dir = dir,
- parms.type = type,
- parms.offset = offset,
- parms.config = (uint8_t *)&global_cfg,
+ parms.dir = dir;
+ parms.type = type;
+ parms.offset = offset;
+ parms.config = (uint8_t *)&global_cfg;
parms.config_sz_in_bytes = sizeof(global_cfg);
tfp = bnxt_ulp_bp_tfp_get(bp, BNXT_ULP_SESSION_TYPE_DEFAULT);
--
2.47.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP
2026-02-27 20:00 ` [PATCH v3] " Mohammad Shuab Siddique
@ 2026-03-03 18:02 ` Kishore Padmanabha
2026-03-11 16:57 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Kishore Padmanabha @ 2026-03-03 18:02 UTC (permalink / raw)
To: Mohammad Shuab Siddique, dev; +Cc: Keegan Freyhof, stable
[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]
Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
-----Original Message-----
From: Mohammad Shuab Siddique <mohammad-shuab.siddique@broadcom.com>
Sent: Friday, February 27, 2026 3:00 PM
To: dev@dpdk.org
Cc: kishore.padmanabha@broadcom.com; Keegan Freyhof
<keegan.freyhof@broadcom.com>; stable@dpdk.org
Subject: [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
Fix compile warnings seen when using clang with the -Wcomma flag in the
bnxt ULP driver code by replacing commas with semicolons.
Bugzilla ID: 1807
Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")
Cc: stable@dpdk.org
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Mohammad Shuab Siddique
<Mohammad-Shuab.Siddique@broadcom.com>
---
drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
index 38cb5c8b31..bc347de202 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_tf.c
@@ -1296,10 +1296,10 @@ ulp_tf_global_cfg_update(struct bnxt *bp,
struct tf *tfp;
/* Initialize the params */
- parms.dir = dir,
- parms.type = type,
- parms.offset = offset,
- parms.config = (uint8_t *)&global_cfg,
+ parms.dir = dir;
+ parms.type = type;
+ parms.offset = offset;
+ parms.config = (uint8_t *)&global_cfg;
parms.config_sz_in_bytes = sizeof(global_cfg);
tfp = bnxt_ulp_bp_tfp_get(bp, BNXT_ULP_SESSION_TYPE_DEFAULT);
--
2.47.3
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5493 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] net/bnxt: fix clang wcomma warnings in ULP
2026-03-03 18:02 ` Kishore Padmanabha
@ 2026-03-11 16:57 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2026-03-11 16:57 UTC (permalink / raw)
To: Mohammad Shuab Siddique; +Cc: dev, stable, Keegan Freyhof, Kishore Padmanabha
03/03/2026 19:02, Kishore Padmanabha:
> Acked-by: Kishore Padmanabha <kishore.padmanabha@broadcom.com>
>
> Fix compile warnings seen when using clang with the -Wcomma flag in the
> bnxt ULP driver code by replacing commas with semicolons.
>
> Bugzilla ID: 1807
> Fixes: dd0191d5e70d ("net/bnxt/tf_ulp: support Thor2 ULP layer")
> Cc: stable@dpdk.org
>
> Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
> Signed-off-by: Mohammad Shuab Siddique
> <Mohammad-Shuab.Siddique@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-11 16:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-27 19:42 [PATCH] net/bnxt: fix clang wcomma warnings in ULP Mohammad Shuab Siddique
2026-02-27 19:53 ` [PATCH v2] " Mohammad Shuab Siddique
2026-02-27 20:00 ` [PATCH v3] " Mohammad Shuab Siddique
2026-03-03 18:02 ` Kishore Padmanabha
2026-03-11 16:57 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox